fixed bg for ios app banner #8704
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Summary
Related Issue: Fixes #8669
🎯 What
just changed dark:brightness-0 to dark:brightness-100 which makes the text visible instead of just a bright white background which was the issue.
🤔 Why
Previously UX was being affected, leaving the user's blank on what this bright box meant. Now after fixing that, it will be clear to the user what that box means which is an option to checkout the new polar app on app store.
🔧 How
First i found the component which was causing this issue, which was clients/apps/web/src/components/Upsell/IOSAppBanner.tsx.
Started a local dev env. on 127.0.0.1:3000, signed up, opened dev tools and targeted that component. Saw that component had a few styles one being dark:brightness-0 , i tried to insert 100 and it worked.
Updated the component with className of dark:brightness-100
🧪 Testing
uv run task testfor backend,pnpm testfor frontend)uv run task lint && uv run task lint_typesfor backend)🖼️ Screenshots/Recordings
before:

after:

📝 Additional Notes
✅ Pre-submission Checklist