Skip to content

Conversation

@anirudhprmar
Copy link

📋 Summary

Related Issue: Fixes #8669

🎯 What

just changed dark:brightness-0 to dark:brightness-100 which makes the text visible instead of just a bright white background which was the issue.

🤔 Why

Previously UX was being affected, leaving the user's blank on what this bright box meant. Now after fixing that, it will be clear to the user what that box means which is an option to checkout the new polar app on app store.

🔧 How

First i found the component which was causing this issue, which was clients/apps/web/src/components/Upsell/IOSAppBanner.tsx.

Started a local dev env. on 127.0.0.1:3000, signed up, opened dev tools and targeted that component. Saw that component had a few styles one being dark:brightness-0 , i tried to insert 100 and it worked.

Updated the component with className of dark:brightness-100

🧪 Testing

  • I have tested these changes locally
  • All existing tests pass (uv run task test for backend, pnpm test for frontend)
  • I have added new tests for new functionality
  • I have run linting and type checking (uv run task lint && uv run task lint_types for backend)

🖼️ Screenshots/Recordings

before:
screenshot-2025-12-26_17-17-13

after:
screenshot-2025-12-26_17-17-35

📝 Additional Notes

✅ Pre-submission Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code where necessary
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated the relevant tests
  • All tests pass locally
  • AI/LLM Policy: If I used AI assistance, I have tested and executed the code locally (not just "vibe-coded")

@vercel
Copy link

vercel bot commented Dec 26, 2025

@anirudhprmar is attempting to deploy a commit to the polar-sh Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

inconsistency in color of "polar app available popup" for mobile screens

1 participant