Open
Conversation
Also add comment explaining subdependencies are pinned to template release
Replace hardcoded version 1.2.2 with variable reference
The @parity/resolc npm package has a bug - see PR comment for details.
a0d24a4 to
4be73c3
Compare
Contributor
Author
|
@nhussein11 will take a look at #1476 and resolve it in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates dependencies in
variables.ymlto resolve open GitHub issues starting with "Update needed:".Closes #1467, closes #1468, closes #1472, closes #1473, closes #1474, closes #1475, closes #1477
Subdependency Issues
These are pinned to the
polkadot_sdk_parachain_templaterelease (v0.0.4) and will be updated when a new template version is released:Closes #1469, closes #1470, closes #1471
Dependencies Updated
Additional Changes
polkadot_sdk_version: polkadot-stable2503-3subdependency topolkadot_sdk_parachain_templatereference/tools/chopsticks.md(now uses variable)The
resolcdependency was not updated andignore_updates: truewas added.Bug Description
The
@parity/resolcnpm package has a bug wherecompile()only requests['abi']inoutputSelection, not bytecode. This breaks:.deploy-basic-pvm.mdwhich expectsevm.bytecode.object--binflag (produces no output)To Reproduce
Root Cause
In js-revive/src/index.ts, the
compile()function hardcodes:Action Needed
An issue should be filed at https://github.com/paritytech/js-revive to fix this bug. Once fixed, the
ignore_updatesflag can be removed and resolc can be updated.Test plan