Ensure assetId is handled correctly when addSignature is used#6083
Merged
polkadot-js-bot merged 3 commits intomasterfrom Jan 29, 2025
Merged
Ensure assetId is handled correctly when addSignature is used#6083polkadot-js-bot merged 3 commits intomasterfrom
polkadot-js-bot merged 3 commits intomasterfrom
Conversation
polkadot-js-bot
approved these changes
Jan 29, 2025
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
polkadot-js/apps#11229 Revealed that when a signer is using
assetIdas a field, theSubmittableExtrinsicclass callsaddSignaturedirectly on theGenerircExtrinsicPayloadV4and bypasses the direct decoding of the assetId option type in theGenericExtrinsicPayload.This PR fixes that and ensures the AssetId via a signer will work as expected.