Skip to content

Improve type registry known defaults implementation to a Map #6127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
polkadot-js-bot merged 1 commit into from
Apr 11, 2025
Merged

Improve type registry known defaults implementation to a Map #6127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/types/src/create/registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ export class TypeRegistry implements Registry {
#unknownTypes = new Map<string, boolean>();
#userExtensions?: ExtDef | undefined;

readonly #knownDefaults: Record<string, CodecClass>;
readonly #knownDefaults: Map<string, CodecClass>;
readonly #knownDefaultsEntries: [string, CodecClass][];
readonly #knownDefinitions: Record<string, Definitions>;
readonly #metadataCalls: Record<string, Record<string, CallFunction>> = {};
Expand All @@ -191,8 +191,8 @@ export class TypeRegistry implements Registry {
public createdAtHash?: Hash;

constructor (createdAtHash?: Hash | Uint8Array | string) {
this.#knownDefaults = objectSpread({ Json, Metadata, PortableRegistry, Raw }, baseTypes);
this.#knownDefaultsEntries = Object.entries(this.#knownDefaults);
this.#knownDefaults = new Map(Object.entries({ Json, Metadata, PortableRegistry, Raw, ...baseTypes }));
this.#knownDefaultsEntries = Array.from(this.#knownDefaults.entries());
this.#knownDefinitions = definitions;

const allKnown = Object.values(this.#knownDefinitions);
Expand Down Expand Up @@ -351,7 +351,7 @@ export class TypeRegistry implements Registry {
}

public getUnsafe <T extends Codec = Codec, K extends string = string> (name: K, withUnknown?: boolean, knownTypeDef?: TypeDef): CodecClass<T> | undefined {
let Type = this.#classes.get(name) || this.#knownDefaults[name];
let Type = this.#classes.get(name) || this.#knownDefaults.get(name);

// we have not already created the type, attempt it
if (!Type) {
Expand Down Expand Up @@ -455,7 +455,7 @@ export class TypeRegistry implements Registry {
}

public hasClass (name: string): boolean {
return this.#classes.has(name) || !!this.#knownDefaults[name];
return this.#classes.has(name) || !!this.#knownDefaults.has(name);
}

public hasDef (name: string): boolean {
Expand Down