Fix duplicate feature test macros#455
Merged
jrybar-rh merged 1 commit intopolkit-org:mainfrom Aug 22, 2024
Merged
Conversation
Closed
notpeelz
force-pushed
the
fix-duplicate-feature-test-macros
branch
from
49a43a4 to
e37250c
Compare
notpeelz
force-pushed
the
fix-duplicate-feature-test-macros
branch
3 times, most recently
from
cfd4bf3 to
418db17
Compare
notpeelz
force-pushed
the
fix-duplicate-feature-test-macros
branch
from
418db17 to
40e65bf
Compare
Contributor
Author
|
@jrybar-rh Now that all the other PRs are merged, this should be ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed feature test macro definitions (i.e
_GNU_SOURCE/_XOPEN_SOURCE) from polkitbackend because_GNU_SOURCEis already defined in the root meson.build.Explicitly defining
_XOPEN_SOURCEis redundant because_GNU_SOURCEimplies_XOPEN_SOURCE 700(according to the comments in glibc'sfeatures.h)Depends on #454