Dont hardcode path to config.h

[notpeelz]

Split from #454 as requested.

This is a minor change that requires meson >= 1.4.0, which isn't available in Fedora 39.
F39 becomes EOL on 2024-11-12.

[vmihalko]

Could you please resolve the conflicts? Then, we can proceed with the merge.

[notpeelz]

Done

CI doesn't have meson 1.4.0 yet. Is that a problem?

[jrybar-rh]

Done

CI doesn't have meson 1.4.0 yet. Is that a problem?

@mrc0mmand: ^

[mrc0mmand]

Hmpf, this is quite a big meson version bump and it cuts off some currently still supported distributions, most importantly Ubuntu Noble (24.04, LTS) - released in Apr 2024, supported until Apr 2029, currently has meson 1.3.2, so I'm still not sure if it's worth it.

As I said in #454 (comment) you don't really have to use full path to the config.h file (IIUC; it works that way fine in systemd), which would drop the requirement for the version bump.

[notpeelz]

Ah... gotta love eternally-outdated distros.

Feel free to close this PR if you don't think it's worth it.

[mrc0mmand]

We had a discussion with @jrybar-rh and @vmihalko and agreed to go ahead with this change.

@notpeelz if you cherry-pick mrc0mmand@a6beaea on top of this PR it should make the CodeQL check happy and this PR should be ready to go.

[notpeelz]

Oh that's great news. I've rebased and applied your patch.

[jrybar-rh]

Ah, here seems to be the hiccup 😄
https://github.com/polkit-org/polkit/actions/runs/13275796335/job/37065055620

[mrc0mmand]

Ah, here seems to be the hiccup 😄 https://github.com/polkit-org/polkit/actions/runs/13275796335/job/37065055620

Ah, whoops, forgot about that one. I'll submit a follow-up.

[mrc0mmand]

Ah, here seems to be the hiccup 😄 https://github.com/polkit-org/polkit/actions/runs/13275796335/job/37065055620

Ah, whoops, forgot about that one. I'll submit a follow-up.

-> #551

[eli-schwartz]

You don't need to bump the minimum required version. You do "need" the full path if polkit can ever be built as a subproject -- the compiler is always run from the global_build_root(), that is, the same directory as the build.ninja file, and config.h is generated where current_build_dir() == project_build_root(), which is the same directory as build.ninja except in a subproject.

But regardless, the string config_h.full_path() is provided for API equivalence with other objects. You could have always reliably guaranteed the location quite simply:

config_h_full_path = meson.current_build_dir() / 'config.h'

No version bump needed.

[mrc0mmand]

Ah, that's actually pretty neat, thanks a lot for the explanation!