Skip to content

test: drop polkit's service memory limits when running under sanitizers#611

Merged
jrybar-rh merged 3 commits intopolkit-org:mainfrom
mrc0mmand:fix-polkit-under-sanitizers
Nov 13, 2025
Merged

test: drop polkit's service memory limits when running under sanitizers#611
jrybar-rh merged 3 commits intopolkit-org:mainfrom
mrc0mmand:fix-polkit-under-sanitizers

Conversation

@mrc0mmand
Copy link
Member

Since running under sanitizers is quite resource hungry.

Follow-up for 7d9c06c.

Since running under sanitizers is quite resource hungry.

Follow-up for 7d9c06c.
systemd v258+ and later (since [0]) doesn't start a user manager
instance for system users by default. This then means there's no user
D-Bus instance for such user and some of our tests fail:

+ container_run_user testuser systemctl status --full --no-pager polkit.service
+ local user=testuser
+ shift
+ systemd-run -M testuser@polkit-container-14392 --user --wait --pipe systemctl status --full --no-pager polkit.service
Failed to connect to system scope bus via local transport: No such file or directory
Failed to start transient service unit: Transport endpoint is not connected

~# journalctl -M polkit-container-14392 -o short-monotonic --no-hostname -u systemd-logind --grep testuser
[ 8259.764687] systemd-logind[180]: New session 'c15' of user 'testuser' with class 'background-light' and type 'unspecified'.

To mitigate this, create a non-system user for the test (i.e. with UUID
>= 1000), so we get the regular user/background instance instead of the
light variants.

[0] systemd/systemd@cf8f6cd
@mrc0mmand mrc0mmand marked this pull request as ready for review November 13, 2025 13:53
@mrc0mmand
Copy link
Member Author

@jrybar-rh this should fix two out of three issues that the CI uncovered (and make it green again).

For the third one I opened systemd/systemd#39714 - it doesn't break the CI per se, but it could hide potential issues, as the journal checks in the dfuzzer test case currently don't work on F42 and newer (as the journal never makes it out of the test container). I'll try to address this as soon as possible (once I figure out what's going on), but it shouldn't be blocking this PR from moving further, espeecially since the checks still work at least in the F41 CI job.

@jrybar-rh jrybar-rh merged commit 242610d into polkit-org:main Nov 13, 2025
40 checks passed
@mrc0mmand mrc0mmand deleted the fix-polkit-under-sanitizers branch November 13, 2025 15:51
@mrc0mmand
Copy link
Member Author

FTR: systemd/systemd#39714 has been fixed and the patch should get backported to v257 as well, so the coredump/sanitizer error collection should start working automagically again soon(-ish)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants