test: do not fail if unshare returns EINVAL#637
Open
bluca wants to merge 1 commit intopolkit-org:mainfrom
Open
test: do not fail if unshare returns EINVAL#637bluca wants to merge 1 commit intopolkit-org:mainfrom
bluca wants to merge 1 commit intopolkit-org:mainfrom
Conversation
On some niche architectures unshare() does not work at all and
returns EINVAL, do not fail the test, as the test's purpose is
not to test unshare().
On HPPA:
1/5 polkit:polkitunixusertest FAIL 3.60s exit status 1
――――――――――――――――――――――――――――――――――――― ✀ ―――――――――――――――――――――――――――――――――――――
stdout:
Test data dir: /<<PKGBUILDDIR>>/test/data
stderr:
Traceback (most recent call last):
File "/<<PKGBUILDDIR>>/test/wrapper.py", line 82, in <module>
setup_test_namespace(args.data_dir)
~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^
File "/<<PKGBUILDDIR>>/test/wrapper.py", line 24, in setup_test_namespace
os.unshare(os.CLONE_NEWNS|os.CLONE_NEWUSER)
~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 22] Invalid argument
https://buildd.debian.org/status/fetch.php?pkg=policykit-1&arch=hppa&ver=127-2&stamp=1770659670&raw=0
Follow-up for 8e17f09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some niche architectures unshare() does not work at all and returns EINVAL, do not fail the test, as the test's purpose is not to test unshare().
On HPPA:
https://buildd.debian.org/status/fetch.php?pkg=policykit-1&arch=hppa&ver=127-2&stamp=1770659670&raw=0
Follow-up for 8e17f09