Merge pull request #41 from pollen-robotics/hotfix-clippy

Apply clippy rules.

Author: pierre-rouanet

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "rustypot"
-version = "0.4.1"
+version = "0.4.2"
 edition = "2021"
 license = "Apache-2.0"
 authors = ["Pollen Robotics"]

src/device/mx.rs

@@ -135,7 +135,7 @@ pub mod conv {
     ///
     /// Works for torque_limit for instance
     pub fn torque_to_dxl_abs_load(torque: f64) -> u16 {
-        assert!(torque >= 0.0 && torque <= 100.0);
+        assert!((0.0..=100.0).contains(&torque));
 
         (torque * 1023.0 / 100.0) as u16
     }

src/protocol/v1.rs

@@ -198,7 +198,6 @@ pub enum DynamixelErrorV1 {
 impl DynamixelErrorV1 {
     fn from_byte(error: u8) -> Vec<Self> {
         (0..7)
-            .into_iter()
             .filter(|i| error & (1 << i) != 0)
             .map(|i| DynamixelErrorV1::from_bit(i).unwrap())
             .collect()
@@ -306,11 +305,11 @@ mod tests {
 
     #[test]
     fn create_write_packet() {
-        let p = PacketV1::write_packet(10, 24, &vec![1]);
+        let p = PacketV1::write_packet(10, 24, &[1]);
         let bytes = p.to_bytes();
         assert_eq!(bytes, [255, 255, 10, 4, 3, 24, 1, 213]);
 
-        let p = PacketV1::write_packet(0xFE, 0x03, &vec![1]);
+        let p = PacketV1::write_packet(0xFE, 0x03, &[1]);
         let bytes = p.to_bytes();
         assert_eq!(bytes, [0xFF, 0xFF, 0xFE, 0x04, 0x03, 0x03, 0x01, 0xF6]);
     }
@@ -327,7 +326,7 @@ mod tests {
 
     #[test]
     fn create_sync_write_packet() {
-        let p = PacketV1::sync_write_packet(&[11, 12], 30, &vec![vec![0x0, 0x0], vec![0xA, 0x14]]);
+        let p = PacketV1::sync_write_packet(&[11, 12], 30, &[vec![0x0, 0x0], vec![0xA, 0x14]]);
         let bytes = p.to_bytes();
         assert_eq!(
             bytes,

src/protocol/v2.rs

@@ -271,7 +271,6 @@ pub enum DynamixelErrorV2 {
 impl DynamixelErrorV2 {
     fn from_byte(error: u8) -> Vec<Self> {
         (1..7)
-            .into_iter()
             .filter(|i| error & (1 << i) != 0)
             .map(|i| DynamixelErrorV2::from_bit(i).unwrap())
             .collect()
@@ -389,7 +388,7 @@ mod tests {
         let p = PacketV2::sync_write_packet(
             &[1, 2],
             116,
-            &vec![
+            &[
                 150_u32.to_le_bytes().to_vec(),
                 170_u32.to_le_bytes().to_vec(),
             ],