Conversation
- Remove OpenHands resolver workflow
- Add path to upload artifact in deploy-apps.yml - Set preview to false in deploy to GitHub Pages - Enable keep_files and disable Jekyll in deploy-pr-previews.yml - Modify PR preview deletion to use shell script
|
🚀 PR Preview deployed! Preview URL: https://pollinations.github.io/hive/pr-120/ |
![mentatbot[bot]](https://avatars.githubusercontent.com/in/837875?s=60&v=4){kind=small}
There was a problem hiding this comment.
The changes in this PR look generally good and improve the deployment workflow system. Here are a few observations for future reference:
-
The removal of the OpenHands resolver workflow suggests a shift away from that system. Make sure this was intentional and that any dependent processes have been updated accordingly.
-
The cleanup process in deploy-pr-previews.yml now uses direct git commands instead of the actions-gh-pages action. While this gives more control, it might be worth adding error handling for cases where:
- The gh-pages branch doesn't exist
- The PR preview directory doesn't exist
- Git operations fail
-
The removal of the root index.html and styles.css suggests the landing page has been moved or replaced. It would be good to ensure there's still a proper landing page for the repository, either in a different location or through a different mechanism.
Overall, these changes seem to streamline the deployment process and remove unused components, which is positive for maintenance and clarity.
Thanks for using MentatBot. Give comments a 👍 or 👎 to help me improve!
You can change my review settings on my settings page.
1 participant
No description provided.