Conversation
This reverts commit 97a4ad6.
|
🚀 PR Preview deployed! Preview URL: https://pollinations.github.io/hive/pr-126/ |
There was a problem hiding this comment.
I've reviewed the changes and have some concerns about the modifications to the deployment workflow:
-
The workflow trigger has been changed from running after "Test Apps" workflow completes to running directly on push events. This removes the requirement for tests to pass before deployment, which could be risky.
-
The workflow is now triggered on:
push: branches: [ main ] paths: - '*/package.json' - '*/index.html' - '*/**'
The
*/**path pattern will essentially match any change in any subdirectory, making the other path patterns redundant. -
The removal of the
workflow_rundependency means we've lost the guarantee that tests pass before deployment. The previous version ensured deployments only happened after successful test runs. -
The version bump in package.json from 1.0.3 to 1.0.6 seems like a large jump. Was there a reason for skipping versions 1.0.4 and 1.0.5?
I recommend:
- Keeping the test workflow dependency to ensure code quality
- If you need to modify the path triggers, be more specific about what changes should trigger deployments
- Document the reasoning for the version jump in package.json
Would you please provide more context about why these changes are needed?
Thanks for using MentatBot. Give comments a 👍 or 👎 to help me improve!
You can change my review settings on my settings page.
No description provided.