Add Funcky.Xunit Packages for xUnit v3#821
Merged
tautropfli merged 1 commit intomainfrom Jan 30, 2025
Merged
Conversation
Member
|
I think you can remove it from v3. Otherwise I think that’s the only nice way, even though it is very stupid.. |
FreeApophis
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xUnit v3 is finally here 🎉
We could either:
Funcky.Xunitto xUnit v3. This means that we force ourselves and our consumers to update to xUnit v3 right now (a lot of third-party libraries such asFsCheck.Xunitare not yet updated to v3).v3to the packages. This is what this PR does.Do we still want to include
ToTheoryDatain v3? The new theory data is much more powerful:TheoryData:TheoryDataby passing it to its constructor: