Add RemoveOrNone to Dictionary extensions#822
Merged
FreeApophis merged 2 commits intomainfrom Jan 30, 2025
Merged
Conversation
eb33b01 to
728a247
Compare
Member
Author
|
I do not understand why PublicAPI check fails. The Signature was autogenerated and it looks the same as for GetValueOrNone. |
Member
|
The failing check is the package validation check from the .NET SDK, not the PublicApi analyzer :) You can run |
Reason: The problem is inheritet from the .NET SDK.
Member
Author
|
The dotnet build with the paramter alone did not work, but I got it to update the suppression file (it was either that i tried pack, or the addition of the value to the csproj file). We already had 3 suppressions, two of them are also because of the SDK change in Dictionary. |
tautropfli
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Remove is an Extension on the
IDictionaryinterface and has an out-parameter returning the removed Item.Even though it has a side effect it maps perfectly to the Try* Pattern.