Updated readme.md #65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The boolean query example used the query() method, which does not exist. Instead, it should use the queryBuilder() method. Additionally, if you pass a *single* parameter to must(), should(), or must_not().. then it will be iterated as though it is an array of class that implement \Sherlock\components\QueryInterface. Therefore, you cannot pass a Term() or Match() class directly to the must(), chould(), or must_not() method as previously shown.
|
Sorry if I'm just being dumb here. I suspect that query() was replaced by queryBuilder() at some point? |
|
Gah, sorry for letting this hang...I'm out of town at the moment. The Readme is definitely wrong (the name did indeed change from query to queryBuilder. Sounds like a bug for must/should/must_not. I'll investigate when I get home |
|
lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The boolean query example used the query() method, which does not exist. Instead, it should use the queryBuilder() method. Additionally, if you pass a single parameter to must(), should(), or must_not().. then it will be iterated as though it is an array of classes that implement \Sherlock\components\QueryInterface.
Therefore, you cannot pass a Term() or Match() class directly to the must(), should(), or must_not() method as previously shown, but must wrap them in an array or pass multiple classes/queries.