First pass at adding additional interfaces and simplifying the layout…#13
Merged
zeerekahmad merged 4 commits intomainfrom Feb 23, 2026
Merged
First pass at adding additional interfaces and simplifying the layout…#13zeerekahmad merged 4 commits intomainfrom
zeerekahmad merged 4 commits intomainfrom
Conversation
…y assigning subsystem_id in control enable
zeerekahmad
commented
Feb 11, 2026
|
|
||
| constexpr uint32_t MAX_SYGNAL_INTERFACES = 6; | ||
| constexpr uint32_t MAX_SYGNAL_SUBSYSTEMS = 1; | ||
| constexpr uint32_t MAX_SYGNAL_SUBSYSTEMS = 2; |
Contributor
Author
There was a problem hiding this comment.
Why would MAX_SYGNAL_SUBSYSTEMS be 2? It's a boolean, it's 0 or 1?
There was a problem hiding this comment.
The usage was comparing like this:
if (subsystem_id >= MAX_SYGNAL_SUBSYSTEMS) {
error_message = error_message + "Subsystem ID exceeds maximum allowed subsystems. \n";
return std::nullopt;
}
The Use of >= made me assume it was the max number of subsystems, not the value of the highest subsystem id.
There was a problem hiding this comment.
So when MAX_SYGNAL_SUBSYSTEMS = 1, this would error out when I tried to send a command to subsystem 1.
Contributor
Author
There was a problem hiding this comment.
This is fine, subsystem ID and # of subsystems are off by 1. This is good enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.