This repository was archived by the owner on Jan 2, 2026. It is now read-only.
Conversation
…eableIdCert where appropriate
added 23 commits
March 25, 2025 21:02
…nd reqwest feature
* Expand ignored file patterns * add wasm_bindgen feature * add wasm_bindgen related optimizations and module * add mod.rs * reconcile lib feature * cargo wasm setup * add wasm-pack-helper script * add files from polyproto-js * reformat file * update wasm settings * bindgen headaches galore!!!!!!!! * add description for wasm module * add no_wee_alloc feature to disable wee_alloc if wasm_bindgen is instrumented through another crate * add license headers
Member
Author
|
i just wanted to try it out dont grill me |
There was a problem hiding this comment.
Pull Request Overview
This pull request prepares the v0.10.0 release by updating version numbers, adding new features such as the WebSocket gateway client, and refining examples and workflows. Key changes include:
- Version and dependency updates in Cargo.toml with adjustments to features (e.g. enabling serde, gateway, and WASM support).
- Updates in the example files to showcase new functionalities such as session creation in the HTTP API example and extended signature/key implementations.
- Enhancements and additions to documentation and GitHub workflows, including new license, coverage, and WASM build/test configurations.
Reviewed Changes
Copilot reviewed 74 out of 83 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| headaches.md | Added a note on challenges with wasm-bindgen and Rust TS/JS bindgen. |
| examples/http_api.rs | Refactored the HTTP client example to leverage sessions and update the test entry point. |
| examples/ed25519_from_der.rs | Introduced consistency improvements and added an as_bytes implementation. |
| examples/ed25519_cert.rs | Made minor adjustments to the signature trait implementation and formatting. |
| examples/ed25519_basic.rs | Extended debug output to include public key OID information. |
| README.md | Updated documentation to reflect the new features and instructions. |
| Cargo.toml | Bumped version, updated Rust edition and dependencies/features. |
| .github/workflows/wasm.yml | Added workflow for building and testing the wasm target. |
| .github/workflows/license-header.yml | Added license header check to GitHub workflows. |
| .github/workflows/coverage.yml | Updated tarpaulin command with feature flags and improved options. |
| .github/workflows/build_and_test.yml | Updated toolchain installation and nextest configuration. |
Files not reviewed (9)
- .github/license-check/config.json: Language not supported
- .github/license-check/header-mpl-2.0.txt: Language not supported
- .vscode/settings.json: Language not supported
- gen-coverage.sh: Language not supported
- scripts/check-license-header.sh: Language not supported
- scripts/fmt.sh: Language not supported
- scripts/gen-coverage.sh: Language not supported
- scripts/test.sh: Language not supported
- scripts/wasm-pack-helper: Language not supported
Member
Author
|
how faintly helpful |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft pull request for release v0.10.0 to receive status and coverage information through GH Actions. Closes #44 and #45
Release v0.10
The tenth release of the polyproto crate is the biggest one yet. It touches almost all areas of the source code and brings numerous improvements, bug fixes and additions.
Most notably, v0.10 has been updated to be almost fully compliant with Beta 1 of the polyproto specification! All the API routes, types and the most important behaviors are there and available for you to tinker and prototype with!
Some more advanced features are missing, though. Notably, v0.10 lacks
zstdWebSocket compression support and advanced migrations features, such as performing and verifying migrations out of the box. Developers and tinkerers can add this functionality themselves, as all the needed "parts" for it exist (API routes, verification behaviors, etc.)—there just isn't one, simple function you can call yet.Things like these are planned for the v0.11 and v0.12 releases.
Gateway
This version ships polyproto WebSocket gateway client functionality, gated behind the
gatewaycrate feature. The implementation of this feature is super backend-agnostic—though, for now, we have sealed the needed traits, and are only shipping atokio-tungstenitebackend for testing.The gateway handles establishing a connection to the server, sending regular heartbeats at the specified interval and responding to Opcode 11—the manual heartbeat request.
Apart from the
Hellopayload, library consumers can easily get access to all messages received from the gateway by callingsubscribe()on the internaltokio::sync::watch::Sender<GatewayMessage>. This means that this crate handles only the bare necessities of connecting to the gateway, and that you are free to handle incoming messages however you would like to. OurGatewayMessagetype is.into()andFrom::<>-compatible withtokio_tungstenite::tungstenite::Message, so that you are not locked into using our types, should you not want that.