[simplex,sdk]: support signing with MPC Vault#707
Open
royvardhan wants to merge 12 commits intomainfrom
Open
Conversation
Wizdave97
reviewed
Mar 17, 2026
Wizdave97
reviewed
Mar 17, 2026
seunlanlege
reviewed
Mar 18, 2026
seunlanlege
reviewed
Mar 18, 2026
seunlanlege
reviewed
Mar 18, 2026
seunlanlege
reviewed
Mar 18, 2026
seunlanlege
reviewed
Mar 18, 2026
Wizdave97
reviewed
Mar 18, 2026
Wizdave97
reviewed
Mar 18, 2026
seunlanlege
reviewed
Mar 18, 2026
seunlanlege
reviewed
Mar 18, 2026
royvardhan
force-pushed
the
roy/external-signing-services
branch
from
9053783 to
59cc159
Compare
royvardhan
force-pushed
the
roy/external-signing-services
branch
from
59cc159 to
24771cd
Compare
Wizdave97
reviewed
Mar 18, 2026
Wizdave97
reviewed
Mar 18, 2026
royvardhan
force-pushed
the
roy/external-signing-services
branch
from
4fbd46f to
d4bec0f
Compare
Wizdave97
reviewed
Mar 23, 2026
| export function createSimplexSigner(config: SignerConfig): SigningAccount { | ||
| if (config.type === SignerType.PrivateKey) { | ||
| const account = privateKeyToAccount(config.privateKey) | ||
| const signRawHash = async (hash: HexString) => { |
Member
There was a problem hiding this comment.
Why not have a PrivateKeySigner type that implements this, then we just initialize that type here
Wizdave97
reviewed
Mar 23, 2026
|
|
||
| if (config.type === SignerType.MpcVault) { | ||
| const { account, service } = createMpcVaultAccount(config.mpcVault) | ||
| const signRawHash = async (hash: HexString) => { |
Member
There was a problem hiding this comment.
Let's implement this directly on the mpc vault type
Wizdave97
reviewed
Mar 23, 2026
| constructor(configService: FillerConfigService, signer?: SigningAccount) { | ||
| this.configService = configService | ||
| this.clientFactory = ViemClientFactory | ||
| this.signer = |
Member
There was a problem hiding this comment.
Why is the signer optional in the constructor? Seems like it should not be
Wizdave97
reviewed
Mar 23, 2026
| const walletClient = this.clientManager.getWalletClient(chain) | ||
| const publicClient = this.clientManager.getPublicClient(chain) | ||
|
|
||
| if (this.signer.mode === "mpcVault") { |
Member
There was a problem hiding this comment.
Seems this would work better once we add more signers
Suggested change
| if (this.signer.mode === "mpcVault") { | |
| if (this.signer.mode !== "privateKey") { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #699
Todos:
On Standby: