Skip to content

Use the same signature threshold used in bsc parlia consensus #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wizdave97 merged 4 commits into from
Mar 17, 2026
Merged

Use the same signature threshold used in bsc parlia consensus #712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4821ae3
update signature threshold in bsc consensus client
Wizdave97 Mar 17, 2026
fb716a5
nit
Wizdave97 Mar 17, 2026
bf8bd41
bump tesseract-consensus
Wizdave97 Mar 17, 2026
410e7b6
nit
Wizdave97 Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ dist/
/pallet-ismp/evm/solidity/cache
.env*
.vscode
.cursor

evm/out/
evm/cache/
Expand Down
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion modules/consensus/bsc/prover/src/test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ async fn verify_bsc_pos_headers() {

// Skip blocks without enough participants (2/3 + 1 threshold)
let participant_count = validators_bit_set.iter().as_bitslice().count_ones();
let required_participants = (2 * validator_set_for_check.len() / 3) + 1;
let required_participants = (2 * validator_set_for_check.len() / 3);
if participant_count < required_participants {
println!(
"Not enough participants in bsc update for block {} ({}/{}), skipping",
Expand Down
6 changes: 3 additions & 3 deletions modules/consensus/bsc/verifier/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@ pub fn verify_bsc_header<H: Keccak256, C: Config>(
)
.map_err(|_| anyhow!("Could not deseerialize vote address set"))?;

if validators_bit_set.iter().as_bitslice().count_ones() <
((2 * current_validators.len() / 3) + 1)
{
// We have to use the same threshold specified in the bsc parlia consensus which is 2/3
// https://github.com/bnb-chain/bsc/blob/da35ee13e2fe38efaeab2d6fb27f112332459b50/consensus/parlia/parlia.go#L557
if validators_bit_set.iter().as_bitslice().count_ones() < ((2 * current_validators.len()) / 3) {
Err(anyhow!("Not enough participants"))?
}

Expand Down
2 changes: 1 addition & 1 deletion parachain/runtimes/gargantua/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
spec_name: Cow::Borrowed("gargantua"),
impl_name: Cow::Borrowed("gargantua"),
authoring_version: 1,
spec_version: 5_000,
spec_version: 5_100,
impl_version: 0,
apis: RUNTIME_API_VERSIONS,
transaction_version: 1,
Expand Down
2 changes: 1 addition & 1 deletion parachain/runtimes/nexus/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
spec_name: Cow::Borrowed("nexus"),
impl_name: Cow::Borrowed("nexus"),
authoring_version: 1,
spec_version: 6_500,
spec_version: 6_600,
impl_version: 0,
apis: RUNTIME_API_VERSIONS,
transaction_version: 1,
Expand Down
2 changes: 1 addition & 1 deletion tesseract/consensus/relayer/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "tesseract-consensus"
version = "1.6.3"
version = "1.6.4"
edition = "2021"

[lib]
Expand Down