Fix useState to support primitive values in setState#56
Open
aym-sekiguchi wants to merge 1 commit intopomber:masterfrom
Open
Fix useState to support primitive values in setState#56aym-sekiguchi wants to merge 1 commit intopomber:masterfrom
aym-sekiguchi wants to merge 1 commit intopomber:masterfrom
Conversation
ea55fba to
0fbdd95
Compare
|
"big picture" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently,
useStatethrows an error when a primitive value (e.g., a number or string) is passed tosetState. This happens becausesetStateexpects a function but directly assigns the value, causing an issue when callingaction(hook.state).This fix ensures that primitive values are correctly handled by converting them into a function before storing them in the queue. This makes
useStatebehave more like React's implementation.Changes
setStateto check ifactionis a function.actionis a primitive value, it is wrapped in a function:(prev) => action.Didactwith React's behavior.Before Fix (Throws an Error)
After Fix (Works Correctly)