Fix ReadyForQuery queue stall with explicit transactions#105
Merged
SeanTAllen merged 2 commits intomainfrom Feb 12, 2026
Merged
Fix ReadyForQuery queue stall with explicit transactions#105SeanTAllen merged 2 commits intomainfrom
SeanTAllen merged 2 commits intomainfrom
Conversation
The query state machine only transitioned to _QueryReady when the
ReadyForQuery status byte was 'I' (idle). Non-idle statuses ('T' for
in-transaction, 'E' for failed transaction) left the state machine in
_QueryNotReady, permanently stalling the queue. This made explicit
transactions (BEGIN/COMMIT/ROLLBACK) unusable.
ReadyForQuery means the server is ready for the next command regardless
of the status byte — the byte is informational, not a readiness gate.
Remove the msg.idle() checks from all five query states and always
transition to _QueryReady. Also remove the msg parameter from
_QueryState.on_ready_for_query since no query state inspects it.
Design: #102
Contributor
|
Hi @SeanTAllen, The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do. Release notes are added by creating a uniquely named file in the The basic format of the release notes (using markdown) should be: Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The query state machine only transitioned to
_QueryReadywhen the ReadyForQuery status byte was'I'(idle). Non-idle statuses ('T'for in-transaction,'E'for failed transaction) left the state machine in_QueryNotReady, permanently stalling the queue. This made explicit transactions (BEGIN/COMMIT/ROLLBACK) unusable.ReadyForQuery means the server is ready for the next command regardless of the status byte — the byte is informational, not a readiness gate. Remove the
msg.idle()checks from all five query states and always transition to_QueryReady. Also remove themsgparameter from_QueryState.on_ready_for_querysince no query state inspects it.Two new integration tests exercise the fix:
Transaction/Commit(exercises status'T') andTransaction/RollbackAfterFailure(exercises status'E').Design: #102