Merged
Conversation
PostgreSQL sends NoticeResponse messages for non-fatal informational feedback (e.g., "table does not exist, skipping" on DROP TABLE IF EXISTS, RAISE NOTICE from PL/pgSQL). The driver previously parsed and silently discarded these. This change surfaces them to users. New NoticeResponseMessage type (separate from ErrorResponseMessage per distinct-semantics-deserve-distinct-representations). Shared field parsing via _ResponseFieldBuilder extracted from the ErrorResponse parser. Notices are delivered in all connected states (including during authentication) since PostgreSQL can send them at any time, unlike LISTEN/NOTIFY notifications which require executing LISTEN first. Includes mock server tests (delivery, mid-data-rows interleaving), integration test (DROP TABLE IF EXISTS), parser tests, and an example.
SeanTAllen
added
the
changelog - added
ponylang-main
added
the
discuss during sync
SeanTAllen
changed the title
ponylang-main
removed
the
discuss during sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL sends NoticeResponse messages for non-fatal informational feedback (e.g., "table does not exist, skipping" on
DROP TABLE IF EXISTS,RAISE NOTICEfrom PL/pgSQL). The driver previously parsed and silently discarded these. This change surfaces them to users via a newpg_noticecallback onSessionStatusNotify.NoticeResponseMessagetype (separate fromErrorResponseMessage— distinct semantics)_ResponseFieldBuilderextracted from the ErrorResponse parserDROP TABLE IF EXISTS), parser tests, and an example