feat(network): add VPN connection management #1087
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the ability to view, activate, and deactivate VPN connections directly from the network applet dropdown menu. Changes: - Add VPN connection discovery via NetworkManager D-Bus API - Implement VPN activate/deactivate handlers - Add collapsible VPN connections section in the UI - Display VPN status (connected/disconnected) with toggle functionality - Position VPN section below wireless networks for easy access VPN connections are discovered from NetworkManager settings and displayed in a dropdown list. Users can click to connect/disconnect VPNs without opening network settings. Active VPN connections show a 'Connected' status. Supports both 'vpn' and 'wireguard' connection types.
|
The resulting menu with 3 VPNs: |
Cheong-Lau
reviewed
Oct 5, 2025
| tracing::error!("Failed to connect to NetworkManager: {:?}", e); | ||
| _ = output | ||
| .send(NetworkManagerEvent::RequestResponse { | ||
| req: NetworkManagerRequest::ActivateVpn(uuid.clone()), |
There was a problem hiding this comment.
🤓 I have a small nit, uuid can just be moved here without cloning, since the error path returns afterwards and doesn't use it anymore. Same thing with name on line 363
Sorry, I had to 🙃, it lgtm otherwise
There was a problem hiding this comment.
Yes, you are absolutely right! Fixed in fa88dcd
Avoid cloning strings that are not needed after move
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to view, activate, and deactivate VPN connections directly from the network applet dropdown menu.
Changes:
VPN connections are discovered from NetworkManager settings and displayed in a dropdown list. Users can click to connect/disconnect VPNs without opening network settings. Active VPN connections show a 'Connected' status.
Supports both 'vpn' and 'wireguard' connection types.