Skip to content

fix(status-area): break from loop instead of unwrapping#1358

Open
wash2 wants to merge 1 commit intomasterfrom
error-handling-status-area
Open

fix(status-area): break from loop instead of unwrapping#1358
wash2 wants to merge 1 commit intomasterfrom
error-handling-status-area

Conversation

@wash2
Copy link
Contributor

@wash2 wash2 commented Mar 19, 2026

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described. (I am not sure how to recreate the panic described in Audio applet uses too much cpu #1316)
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@wash2 wash2 requested review from a team and ids1024 March 19, 2026 14:45
@ids1024
Copy link
Member

ids1024 commented Mar 19, 2026

This code is also in https://github.com/pop-os/cosmic-comp/blob/master/src/dbus/name_owners.rs, so if it can panic, we'll presumably need to fix it there too.

Though I'm also not sure how to reproduce this, or in what circumstance it would panic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants