Skip to content

Fix mimetype based filtering in dialog#1650

Open
hojjatabdollahi wants to merge 2 commits intopop-os:masterfrom
hojjatabdollahi:hojjat/fix-open-dialog-mime
Open

Fix mimetype based filtering in dialog#1650
hojjatabdollahi wants to merge 2 commits intopop-os:masterfrom
hojjatabdollahi:hojjat/fix-open-dialog-mime

Conversation

@hojjatabdollahi
Copy link
Contributor

@hojjatabdollahi hojjatabdollahi commented Feb 23, 2026

Dialog is trying to match a mime text exactly, making "image/*" not match with "image/png".

How to reproduce:
Try to change your avatar in Fractal:
image

Should fix pop-os/xdg-desktop-portal-cosmic#242.


  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

It used to try to match images/* to the image/png and fail. Now it
matches the type if the subtype is STAR.
@jackpot51 jackpot51 requested a review from a team February 25, 2026 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File chooser/picker does not show applicable files

2 participants