Skip to content

make script POSIX-compliant#193

Open
LinuxBoy-96 wants to merge 1 commit intopop-os:masterfrom
LinuxBoy-96:sh2
Open

make script POSIX-compliant#193
LinuxBoy-96 wants to merge 1 commit intopop-os:masterfrom
LinuxBoy-96:sh2

Conversation

@LinuxBoy-96
Copy link

It might be worth minimizing Bash-specific usage where possible to improve portability and reduce hard dependencies. If this can be written in POSIX sh without losing clarity, it could simplify the runtime environment.

I'm not a shell expert and I find shell scripts difficult to read, so I use AI to help identify Bash-specific constructs. The changes were then tuned manually by me until they were validated on https://www.shellcheck.net/
as POSIX-compatible and free of bashisms.

it's portable and even more solid.

  • I have disclosed use of any AI generated code in my commit messages.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

Refactor script to improve POSIX compliance and error handling.
@LinuxBoy-96
Copy link
Author

@mmstick Back at it again with everything you wanted... this is not the same PR, the first one had a conflict that I messed up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant