Open
Conversation
Refactor script to improve POSIX compliance and error handling.
Author
|
@mmstick Back at it again with everything you wanted... this is not the same PR, the first one had a conflict that I messed up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It might be worth minimizing Bash-specific usage where possible to improve portability and reduce hard dependencies. If this can be written in POSIX sh without losing clarity, it could simplify the runtime environment.
I'm not a shell expert and I find shell scripts difficult to read, so I use AI to help identify Bash-specific constructs. The changes were then tuned manually by me until they were validated on https://www.shellcheck.net/
as POSIX-compatible and free of bashisms.
it's portable and even more solid.