feat(sound): redesign with separate device profiles page

[mmstick]

Closes #1325
Closes pop-os/cosmic-epoch#655
Closes pop-os/cosmic-epoch#787
Closes pop-os/cosmic-epoch#946
Closes pop-os/cosmic-epoch#1001
Closes pop-os/cosmic-epoch#568
Closes pop-os/cosmic-epoch#1368

• Device profiles have been moved into a new Device Profiles sub-page for selecting profiles per device
  • Set with wpctl set-profile {{device-id}} {profile-index}} instead of pactl
• Setting the default sink (output) and source (input) now operates independently
  • Set with wpctl set-default {{node-id}}
• All of our devices now have stable node object and device IDs from pipewire-rs
  - Enables using wpctl for setting card profiles, default sinks/sources, volume, and mute
  - Significant performance and stability improvements
  - Wireplumber state no longer gets corrupted
• Fixed early return on debounced volume events dropping pipewire and pulse events
• Update pipewire-rs to version 0.9
• Most of our dependency on libpulse has been eliminated
  • It is only used for getting and setting volume, volume balance, and watching default sink/source changes

[jacobgkau]

First, there's an overflow/sizing issue with the drop-down box on the Device Profiles page. By default, I had no profile selected (not even "Off"), which seems impossible. In that state, most of the drop-down items flowed out of the end of the window:

It seems like longer labels being selected allowed the drop-down to display more of its contents:

Separate issue, but after I selected "Off" as my profile, the device disappeared from the list, making it impossible to turn on again. The point of the "Off" option is to still show the device in the list while it's disabled, so that shouldn't happen.

[mmstick]

What's the output of pw-dump on this system? This is what I see on a system with a Realtek card, Radeon HDMI audio, and a USB-C sound card.

[mmstick]

Fixed the devices on the device profiles page disappearing when setting their profile to off. Which also fixes the device briefly disappearing when the device's nodes are replaced.

[jacobgkau]

On the same machine as yesterday, I still had one of the devices not have any profile visibly selected at first, which shouldn't be possible:

Here is pw-dump from that system: pw-dump-oryp8.txt

If I set the device to "Off", it initially shows itself as "Off", but if I reboot, I end up in the same state as shown above (it boots up set to nothing instead of showing as set to "Off".)

[jacobgkau]

I'm still also seeing menu items getting cut off at the edge of the window. Is that a libcosmic bug? Dropdown menus in other COSMIC apps seem to be able to run out the side of the window.

[mmstick]

It's a different dropdown widget. I will switch to it

[mmstick]

The index of the selected profile on that Built-in Audio device should be fixed now

[jacobgkau]

On 8688b54 and oryp8, the profile of Built-in Audio keeps defaulting to Digital Surround 5.1 (IEC958/AC3) Output. I think this corresponds to the S/PDIF output, but attempting to change the volume does nothing. Going directly to Digital Stereo (IEC958) Output doesn't work, but if I choose Off, then I can go to Digital Stereo (IEC958) Output to get sound out of the S/PDIF port (the Digital Surround option then gives distorted audio if I select that again).

If I just boot (defaulting to Digital Surround 5.1 (IEC958/AC3) Output) and change directly to one of the Analog Stereo options, that also doesn't work (changing the volume doesn't work & there's no sound). Again, I have to select Off first, then go back to Analog Stereo for it to work.

I know some of this might be audio card weirdness that's outside the scope of COSMIC Settings, but does any of this sound like a COSMIC Settings thing? The two distinct problems are the default/last selected profile not being saved between sessions, and not being able to switch from the default to one of the others successfully without first selecting Off (or possibly just sound not working at all until it's turned Off).

[jacobgkau]

From @WatchMkr in Mattermost (posting here so it doesn't get lost)-- the design also calls for the device description to be prepended to the profile name when selecting an input/output device (e.g. Speakers - Built-in Audio). The string to be prepended appears to be labeled "description" in pw-dump.

[mmstick]

Seems I'll need to add the different routes (ports) to the output/input dropdown lists. Pavucontrol puts those on a separate port dropdown.

[jacobgkau]

Not sure if you were ready for me to look at this again yet, but just to corroborate, on f787c83, I'm seeing the Output device as Analog Stereo - Built-in Audio, when it should say Speakers - Built-in Audio. As you noted, it should be the description of the route, not the profile.

The other problems I mentioned before are still occurring.

[jacobgkau]

35e3127 still has reliability issues on oryp8.

If I set Built-in Audio's profile to Analog Stereo Duplex and then reboot, it defaults to Digital Surround 5.1 (IEC958/AC3) Output again.

If I change the profile to Analog Stereo Duplex, then both Output device and Input device show their only option as Built-in Audio, with no route name/description prepended. Changing the speaker volume with hotkeys doesn't work in this state.

If I change the profile to Analog Stereo Output, then Output device changes to Speakers - Built-in Audio, and the speaker hotkeys work. Alternatively, if I open up an app and start playing audio, then the Output device does not change, but the speaker hotkeys do start working.

[mmstick]

What's the output of pw-dump when set to Analog Stereo Duplex? Particularly the Pipewire:Interface:Node associated with it. Changing the profile changes the active route, and a PipeWire:Interface:Node is created from that.

Based on the logic that I have, the most likely problem is that the node failed to parse. The node ID is required to set a default sink/source, and the route won't be added to the device name if a node isn't associated with it.

[mmstick]

This is where the node is parsed. This could be wrapped with dbg!(Node::from_node(info)) to check if all nodes are getting parsed.

[jacobgkau]

Here is pw-dump after booting on 4a14492, defaulting to S/PDIF: oryp8-4a14492-default-spdif.txt
Here is pw-dump after changing the profile to Analog Stereo Duplex: oryp8-4a14492-duplex.txt

On 4a14492, the speaker hotkeys work immediately after changing the profile to Analog Stereo Duplex, but the Output device is only labeled Built-in Audio, while the Input device is labeled Speakers - Built-in Audio.

[mmstick]

I think I see the issue

[mmstick]

Hoping this fixes the issue you're seeing.

[mmstick]

Switched to using libpulse for monitoring active port changes, and I'm seeing it switch between Speakers and Headphones on my system. Checking the Pro Audio issue now.