feat(wifi): add search functionality for filtering WiFi networks by manascb1344 · Pull Request #1592 · pop-os/cosmic-settings

manascb1344 · 2025-11-29T18:23:06Z

Description

This PR adds search/filter functionality to the WiFi settings page, allowing users to easily find WiFi networks when there are many available networks (50+). The search includes both currently visible networks and known/saved networks, even if they're not currently visible.

Fixes #1589

Problem

When there are many WiFi networks available, it becomes difficult to manually search through the list to find a specific SSID. Additionally, the interface reloads every 2-3 seconds, causing the network order to change, making it even harder to locate networks.

Screenshots

Related Issues

Closes #1589

manascb1344 · 2025-11-29T18:24:39Z

@jacobgkau Please have a look!

mmstick · 2025-12-01T17:33:02Z

Since this isn't in our Figma design specs, it needs design approval by @maria-komarova first.

maria-komarova · 2025-12-03T21:25:44Z

I would suggest we only show search within "Visible networks" section and only when there are 30+ networks.

For the refresh rate I would love to better understand why networks jump around that much. Maybe we can refresh less frequently but I need more information first.

jacobgkau · 2025-12-03T22:08:13Z

For the refresh rate I would love to better understand why networks jump around that much. Maybe we can refresh less frequently but I need more information first.

Not sure about the frequency, but the reason they jump around is because they're currently sorted by signal strength, and signal strength of wireless networks often changes slightly (based on the environment) between different scans.

Maybe quantizing the signal strength (e.g. chunking in groups of "5-bar, 4-bar," etc.) and then sorting alphabetically within those groups, or a similar solution, could prevent it from happening quite as much? (There would still be some networks going between the different bar groups, but it would prevent e.g. a 3.05-bar and 3.06-bar from swapping in the list constantly.)

maria-komarova · 2025-12-03T22:12:23Z

Maybe quantizing the signal strength (e.g. chunking in groups of "5-bar, 4-bar," etc.) and then sorting alphabetically within those groups, or a similar solution, could prevent it from happening quite as much? (There would still be some networks going between the different bar groups, but it would prevent e.g. a 3.05-bar and 3.06-bar from swapping in the list constantly.)

I like this idea, sounds like it would be an improvement.

- Move search input from top-level to inside "Visible Networks" section - Only show search when 30+ visible networks exist (per designer spec) - Known Networks section now always unfiltered (search only applies to visible) - "No networks found" message only shown in visible section when search active - Addresses designer feedback from PR pop-os#1592

- Clear search_query in on_leave() to prevent stale filter on return - Apply cargo fmt formatting fixes

manascb1344 · 2025-12-06T12:36:22Z

Updated implementation based on @maria-komarova's feedback

I've updated the implementation to match the design requirements:

Changes made:

Search bar moved inside "Visible Networks" section: no longer at page top level
30+ network threshold: search only appears when wireless_access_points.len() >= 30
Known Networks always unfiltered: search only filters visible networks

Screenshots:

With fewer than 30 networks (search hidden):

With search bar (I have reduced the threshold to 2 instead of 30 for testing):

Note on testing:

The 30+ threshold means the search bar won't appear in most home/small office environments. For testing, reviewers can temporarily change line 1007 in wifi.rs:
let show_search = state.wireless_access_points.len() >= 30;
// Change to >= 3 for testing, then revert

@maria-komarova @jacobgkau @mmstick

manascb1344 · 2025-12-07T15:29:30Z

Hi @jacobgkau
Can you review this once.

manascb1344 · 2025-12-24T06:26:45Z

@jacobgkau any updates ?

Resolved conflicts in wifi.rs by combining search functionality with master branch improvements: - Adopted conditional display of QR code and Forget buttons (only for known networks) - Updated popup styling to match master (width 200.0, Dropdown class, padding) - Preserved search functionality for filtering WiFi networks

leviport · 2026-02-05T23:16:42Z

This has conflicts now. Can you resolve those? Then we'll be able to test this once we have time.

…ssage - Renamed variable for clarity in the connection logic. - Added a new translation for "no search results" in the i18n file. - Updated comments to better describe the search functionality in the devices view.

manascb1344 · 2026-02-06T13:01:26Z

@leviport @mmstick Ive fixed the merge conflicts

garrettjwilke · 2026-02-06T16:52:33Z

due to lack of 30+ wireless networks, i am unsure how to test this

30 networks is a lot..

manascb1344 · 2026-02-06T17:45:41Z

due to lack of 30+ wireless networks, i am unsure how to test this

30 networks is a lot..

The 30+ threshold means the search bar won't appear in most home/small office environments. For testing, reviewers can temporarily change line 1007 in wifi.rs:
let show_search = state.wireless_access_points.len() >= 30;
// Change to >= 3 for testing, then revert

garrettjwilke

this works very well

it allows you to search for strings nested inside of a network name, so if the network is called test_network_519 you can simply type in 519 and it still works.

i am guessing the 30 network limit will make this feature not work for most people and i suggest a lower limit.

EDIT:
passes regression testing

Testing

This document provides a regression testing checklist for COSMIC Settings and the COSMIC Settings Daemon. The checklist provides a starting point for Quality Assurance reviews.

Checklist

Network & Wireless

Wi-Fi

Able to disconnect from and connect to a network.

Desktop

Wallpaper

Clicking a different wallpaper switches to it immediately
Leaving the page and coming back does not change the wallpaper

Appearance

Open a COSMIC app and a GNOME app. When switching between Dark and Light mode, the COSMIC app switches immediately, and the GNOME app switches after restarting.
Changing the accent color works.
Changing the roundness style works and does not affect other aspects of the theme (e.g. color mode).
Changing the interface density works.

Panel

Enable tiling. "Automatically hide panel" takes effect immediately.
Disable tiling; maximize a window. "Automatically hide panel" takes effect immediately.

Dock

Enable tiling. "Automatically hide dock" takes effect immediately.
Disable tiling; maximize a window. "Autommatically hide dock" takes effect immediately.
Changing position on screen works.
All Style settings take effect as expected.

Displays

Plug in a second display. Displays can be rearranged via dragging.

Sound

TBD after devices/profiles are fixed.

Power & Battery

Changing power mode takes effect and is reflected by top panel applet.

Input Devices

Touchpad

All click behavior settings work as expected.
All scrolling settings work as expected.

Applications

Default Applications

Changing the default terminal affects Super-T shortcut.

X11 Applications Compatibility

Global Shortcuts in X11 Applications works (in e.g. Discord).

Time & Language

Date & Time

Changing time zome works.
Toggling 24-hour time takes effect in Settings preview, on top panel, and on the lock screen.
Toggling seconds takes effect in Settings preview and on top panel.
Changing first day of week takes effect in Calendar applet.
Turning date on/off for applet works.

System & Accounts

About

Changing hostname works (check terminal prompt).

manascb1344 · 2026-02-07T09:11:58Z

I’d suggest lowering the threshold to 15 (or even 10) so the feature is available when it’s actually useful, while still keeping it hidden in simpler setups. Happy to update the implementation accordingly if that sounds reasonable.

leviport · 2026-02-12T19:53:57Z

@maria-komarova what do you think the threshold should be? I think 15 sounds good, myself. Although 10 might be useful on smaller displays.

maria-komarova · 2026-02-13T19:56:52Z

I wouldn't go below 15. It seems that 10 is easy enough to scan through so search might not be needed in this case. Sure, there are always people who prefer search but I'm not sure how much of an improvement it is between scanning through the list vs searching if we set the threshold to 10.

manascb1344 · 2026-02-17T07:12:12Z

@jacobgkau Ive fixed the merge conflicts

leviport

Working great with a limit of 15. Thanks!

Regression testing passed again:

Network & Wireless

Wi-Fi

Able to disconnect from and connect to a network.

Desktop

Wallpaper

Clicking a different wallpaper switches to it immediately
Leaving the page and coming back does not change the wallpaper

Appearance

Open a COSMIC app and a GNOME app. When switching between Dark and Light mode, the COSMIC app switches immediately, and the GNOME app switches after restarting.
Changing the accent color works.
Changing the roundness style works and does not affect other aspects of the theme (e.g. color mode).
Changing the interface density works.

Panel

Enable tiling. "Automatically hide panel" takes effect immediately.
Disable tiling; maximize a window. "Automatically hide panel" takes effect immediately.

Dock

Enable tiling. "Automatically hide dock" takes effect immediately.
Disable tiling; maximize a window. "Autommatically hide dock" takes effect immediately.
Changing position on screen works.
All Style settings take effect as expected.

Displays

Plug in a second display. Displays can be rearranged via dragging.

Sound

TBD after devices/profiles are fixed.

Power & Battery

Changing power mode takes effect and is reflected by top panel applet.

Input Devices

Touchpad

All click behavior settings work as expected.
All scrolling settings work as expected.

Applications

Default Applications

Changing the default terminal affects Super-T shortcut.

X11 Applications Compatibility

Global Shortcuts in X11 Applications works (in e.g. Discord).

Time & Language

Date & Time

Changing time zome works.
Toggling 24-hour time takes effect in Settings preview, on top panel, and on the lock screen.
Toggling seconds takes effect in Settings preview and on top panel.
Changing first day of week takes effect in Calendar applet.
Turning date on/off for applet works.

System & Accounts

About

Changing hostname works (check terminal prompt).

feat(wifi): add search functionality for filtering WiFi networks

d3f7676

Merge branch 'master' into wifi-search-filter

697f762

mmstick requested a review from a team December 1, 2025 17:32

mmstick added the needs-design label Dec 2, 2025

Merge branch 'master' into wifi-search-filter

154c3c6

Copilot AI review requested due to automatic review settings December 4, 2025 03:49

Copilot started reviewing on behalf of manascb1344 December 4, 2025 03:50 View session

Copilot finished reviewing on behalf of manascb1344 December 4, 2025 03:53

This comment was marked as spam.

Sign in to view

manascb1344 and others added 3 commits December 6, 2025 15:30

Merge branch 'master' into wifi-search-filter

10a3645

fix(wifi): reset search query on page leave and apply formatting

4dd874d

- Clear search_query in on_leave() to prevent stale filter on return - Apply cargo fmt formatting fixes

manascb1344 force-pushed the wifi-search-filter branch from d94af7b to 0dec524 Compare December 24, 2025 06:45

mmstick requested review from a team February 2, 2026 13:59

manascb1344 and others added 2 commits February 6, 2026 18:13

Merge branch 'master' into wifi-search-filter

6028bb2

mmstick previously approved these changes Feb 6, 2026

View reviewed changes

garrettjwilke previously approved these changes Feb 6, 2026

View reviewed changes

fix(wifi): Update search threshold from 30 to 15

7b285b3

jacobgkau dismissed stale reviews from garrettjwilke and mmstick via 7b285b3 February 16, 2026 17:31

Merge origin/master into wifi-search-filter

b515f3c

leviport requested review from a team and garrettjwilke February 18, 2026 23:41

manascb1344 requested a review from mmstick February 19, 2026 05:53

leviport self-assigned this Feb 19, 2026

Merge branch 'master' into wifi-search-filter

f22f2a1

leviport removed the request for review from garrettjwilke February 19, 2026 21:09

leviport previously approved these changes Feb 19, 2026

View reviewed changes

Fix rustfmt formatting issues

65c6e7e

manascb1344 dismissed leviport’s stale review via 65c6e7e February 20, 2026 04:50

Comments

Conversation

manascb1344 commented Nov 29, 2025

Description

Problem

Screenshots

Related Issues

Uh oh!

manascb1344 commented Nov 29, 2025

Uh oh!

mmstick commented Dec 1, 2025

Uh oh!

maria-komarova commented Dec 3, 2025

Uh oh!

jacobgkau commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maria-komarova commented Dec 3, 2025

Uh oh!

This comment was marked as spam.

Uh oh!

manascb1344 commented Dec 6, 2025

Updated implementation based on @maria-komarova's feedback

Changes made:

Screenshots:

Note on testing:

Uh oh!

manascb1344 commented Dec 7, 2025

Uh oh!

manascb1344 commented Dec 24, 2025

Uh oh!

leviport commented Feb 5, 2026

Uh oh!

manascb1344 commented Feb 6, 2026

Uh oh!

garrettjwilke commented Feb 6, 2026

Uh oh!

manascb1344 commented Feb 6, 2026

Uh oh!

garrettjwilke left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Testing

Checklist

Network & Wireless

Wi-Fi

Desktop

Wallpaper

Appearance

Panel

Dock

Displays

Sound

Power & Battery

Input Devices

Touchpad

Applications

Default Applications

X11 Applications Compatibility

Time & Language

Date & Time

System & Accounts

About

Uh oh!

manascb1344 commented Feb 7, 2026

Uh oh!

leviport commented Feb 12, 2026

Uh oh!

maria-komarova commented Feb 13, 2026

Uh oh!

manascb1344 commented Feb 17, 2026

Uh oh!

leviport left a comment

Choose a reason for hiding this comment

Network & Wireless

Wi-Fi

Desktop

Wallpaper

Appearance

Panel

jacobgkau commented Dec 3, 2025 •

edited

Loading

garrettjwilke left a comment •

edited

Loading