fix(wallpaper): deduplicate custom wallpaper entries#1863
Merged
jacobgkau merged 1 commit intopop-os:masterfrom Feb 24, 2026
Merged
fix(wallpaper): deduplicate custom wallpaper entries#1863jacobgkau merged 1 commit intopop-os:masterfrom
jacobgkau merged 1 commit intopop-os:masterfrom
Conversation
Member
|
Make sure to rebase your branch. There are some stale commits in here. |
ee444a0 to
d5baa6d
Compare
d5baa6d to
42c10ce
Compare
Contributor
Author
|
Done. Rebased onto upstream master and cleaned up the commit history. Please take another look. |
mmstick
approved these changes
Feb 21, 2026
jacobgkau
approved these changes
Feb 24, 2026
Member
jacobgkau
left a comment
There was a problem hiding this comment.
As described, the wallpaper page used to allow adding the same image multiple times, although it only showed up once after the page was left and reloaded. This PR fixes that bug. All other settings on this page are still working as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the same custom wallpaper could be added multiple times
to the selection list, even though it was only stored once in the config.
The UI layer did not check for existing paths before inserting new entries,
which caused duplicate items to appear.
This change ensures that custom images are deduplicated based on their path
before being added to the in-memory selection state.
Before:

After:
