Skip to content

Comments

fix(wallpaper): deduplicate custom wallpaper entries#1863

Merged
jacobgkau merged 1 commit intopop-os:masterfrom
istekhar8966:fix-wallpaper-duplicates
Feb 24, 2026
Merged

fix(wallpaper): deduplicate custom wallpaper entries#1863
jacobgkau merged 1 commit intopop-os:masterfrom
istekhar8966:fix-wallpaper-duplicates

Conversation

@istekhar8966
Copy link
Contributor

@istekhar8966 istekhar8966 commented Feb 20, 2026

This fixes an issue where the same custom wallpaper could be added multiple times
to the selection list, even though it was only stored once in the config.

The UI layer did not check for existing paths before inserting new entries,
which caused duplicate items to appear.

This change ensures that custom images are deduplicated based on their path
before being added to the in-memory selection state.

Before:
image

After:
image

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@mmstick mmstick requested review from a team February 20, 2026 20:39
@mmstick
Copy link
Member

mmstick commented Feb 20, 2026

Make sure to rebase your branch. There are some stale commits in here.

@istekhar8966 istekhar8966 force-pushed the fix-wallpaper-duplicates branch from ee444a0 to d5baa6d Compare February 20, 2026 20:48
@istekhar8966 istekhar8966 force-pushed the fix-wallpaper-duplicates branch from d5baa6d to 42c10ce Compare February 20, 2026 20:55
@istekhar8966
Copy link
Contributor Author

Done. Rebased onto upstream master and cleaned up the commit history. Please take another look.
Thanks!

@istekhar8966 istekhar8966 requested a review from mmstick February 21, 2026 14:34
@jacobgkau jacobgkau self-assigned this Feb 23, 2026
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As described, the wallpaper page used to allow adding the same image multiple times, although it only showed up once after the page was left and reloaded. This PR fixes that bug. All other settings on this page are still working as expected.

@jacobgkau jacobgkau merged commit 28c3510 into pop-os:master Feb 24, 2026
14 checks passed
@istekhar8966 istekhar8966 deleted the fix-wallpaper-duplicates branch February 24, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants