WIP: Mod-Tap support with QMK #79
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This could get merged behind an experimental features menu so this doesn't stay in draft forever. @ids1024 |
|
Something like that might be possible, since the main concern here is just finding a good UI for it. |
|
Feature beats UI to me for this. Maybe add a disclaimer for the experimental feature UI not being the most polished. |
|
yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be working now, but the PR is a draft pending a better UI. Don't know if @maria-komarova or anyone else has ideas on it.
As implemented currently, it adds a check box and a dropdown at the bottom of the keycode picker. Not sure that's the best solution:
Currently it doesn't properly format the text for the mod-tap keycode when displaying it on the keyboard, instead just showing something like
MT(LEFT_CTRL, A). Not sure what could be displayed that would be short enough and clear...One strange limitation of mod-tap, as mentioned in QMK's documentation, is that it only works with keycodes up to 255, so some of them don't work with the feature. This branch thus sets the sensitivity of keys appropriately, as seen here. Not sure if there's anything that would make this clearer.
Resolves #64.