fix(dropdown): missing icon on windows #972
Conversation
| #[cfg(target_os = "linux")] | ||
| let icon = icon::from_name("pan-down-symbolic").size(16).handle(); | ||
| #[cfg(not(target_os = "linux"))] | ||
| let icon = icon::from_svg_bytes(include_bytes!("../../../res/icons/pan-down-symbolic.svg")) |
There was a problem hiding this comment.
This should be a static global variable, and shared between other widgets that are also using this icon. The multi dropdown and table widgets also use this icon.
There was a problem hiding this comment.
So something like this? A function is used to clone it for convenience, since references to an icon::Handle aren't useful. 31fa09a...48ffffd
Or would it be preferable to wrap the icon in a struct that passes through function calls to the inner icon::Named on Linux, but those functions do nothing on Windows since they're not relevant for from_svg_bytes icons? That way the caller doesn't need to care about whether or not the icon is bundled. 31fa09a...8944f59
There was a problem hiding this comment.
I have some ideas. I'll look into this soon
2 participants
No description provided.