fan: Tests and cleanups for the interpolation functions #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have two tests for the case were temp is greater than both points so drop one of these tests. We also don't have any interpolation test for the case where temp is strictly between the points. This change adds one. Signed-off-by: Andrei Gherzan <[email protected]>
Signed-off-by: Andrei Gherzan <[email protected]>
First of all, this clarifies what kind of interpolation is done in "interpolate_duties" by renaming it to "linear_interpolation_duty". This function mathematically handles the cases where the point to be fit is one of the boundaries so there is no need for extra logic of that in "get_duty_between_points". This change also includes some minor rewordings and formatting. Signed-off-by: Andrei Gherzan <[email protected]>
mmstick
approved these changes
Nov 3, 2022
|
This is very old. Does it make sense to keep it open? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.