Skip to content

Comments

Add search functionality#26

Merged
popey merged 2 commits intomainfrom
add-search-feature
Nov 16, 2025
Merged

Add search functionality#26
popey merged 2 commits intomainfrom
add-search-feature

Conversation

@popey
Copy link
Owner

@popey popey commented Nov 16, 2025

Summary

Implements search functionality for grummage, addressing issue #6.

Key Features

Search Functionality:

  • Press / to open search modal
  • Search matches within the current view (case-insensitive substring match)
  • Press n to navigate to next result
  • Press N to navigate to previous result
  • Automatically jumps to first result when search completes
  • Shows result count and current position in status bar
  • Clears search state when switching views

UI Improvements:

  • Tree root now expands automatically after loading, making content immediately visible
  • Tree root label now reflects the current view:
    • "Packages" for package view
    • "Vulnerabilities" for vulnerability view
    • "Package Types" for type view
    • "Severity Levels" for severity view

Keybinding Changes:

  • Changed package view from n to p to avoid conflict with search navigation
  • n and N are now dedicated to search (next/previous result)

Testing

  • Tested search across all view modes
  • Verified automatic jump to first result
  • Verified tree expansion on load
  • Confirmed search clears when switching views

Documentation

  • Updated help text with new keybindings
  • Updated README with search documentation

Fixes #6

🤖 Generated with Claude Code

- Add search modal with / key to search within current view
- Implement n for next result and N for previous result
- Automatically jump to first search result when search completes
- Expand tree root by default to show content immediately after loading
- Fix tree root labels to reflect current view mode:
  * "Packages" for by_package view
  * "Vulnerabilities" for by_vuln view
  * "Package Types" for by_type view
  * "Severity Levels" for by_severity view
- Change package name view key from n to p to avoid conflict with search
- Update help text and README with new search functionality
- Clear search results when switching views

Fixes #6

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Update help text to use argparse format from main
- Include new search keybindings (/, n, N)
- Update package view keybinding from n to p
@popey popey merged commit be2d1b3 into main Nov 16, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add search option

1 participant