Skip to content

Commit 153c65e

Browse files
committed
[estimate] add --multi option; default false
1 parent 1a7be5d commit 153c65e

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

smcpp/analysis.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -418,7 +418,7 @@ def __init__(self, files, args):
418418
self._init_inference_manager(args.polarization_error)
419419
self._init_optimizer(args.outdir,
420420
args.algorithm, args.xtol, args.ftol,
421-
learn_rho=args.r is None, single=False)
421+
learn_rho=args.r is None, single=not args.multi)
422422

423423

424424
def _init_parameters(self, mu, r):
@@ -527,7 +527,7 @@ def __init__(self, files, args):
527527
self._perform_thinning(args.thinning)
528528
# Further initialization
529529
self._init_inference_manager(args.polarization_error)
530-
self._init_optimizer(args.outdir, args.algorithm, args.xtol, args.ftol, True)
530+
self._init_optimizer(args.outdir, args.algorithm, args.xtol, args.ftol, single=True)
531531
self._niter = 1
532532

533533
def _validate_data(self):

smcpp/commands/command.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,15 +58,14 @@ def add_common_estimation_args(parser):
5858
"from mean heterozygosity",
5959
action="store_true", default=False)
6060
optimizer = parser.add_argument_group("Optimization parameters")
61-
optimizer.add_argument(
62-
"--no-initialize", action="store_true", default=False, help=argparse.SUPPRESS)
61+
optimizer.add_argument("--no-initialize", action="store_true", default=False, help=argparse.SUPPRESS)
6362
optimizer.add_argument('--em-iterations', type=int,
6463
help="number of EM steps to perform", default=20)
6564
optimizer.add_argument('--algorithm',
6665
choices=["BFGS", "L-BFGS-B", "TNC", "AdaMax", "Adam"],
6766
default="L-BFGS-B", help=argparse.SUPPRESS)
68-
optimizer.add_argument('--blocks', type=int,
69-
help="number of coordinate ascent blocks. default: min(4, K)")
67+
optimizer.add_argument('--multi', default=False, action="store_true",
68+
help="update multiple blocks of coordinates at once")
7069
optimizer.add_argument("--ftol", type=float,
7170
default=smcpp.defaults.ftol,
7271
help="stopping criterion for relative improvement in loglik "

0 commit comments

Comments
 (0)