Skip to content

Commit 7592fa8

Browse files
committed
change default to coord ascent
1 parent 129d99b commit 7592fa8

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

smcpp/analysis/analysis.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ def __init__(self, files, args):
5353
args.xtol,
5454
args.ftol,
5555
learn_rho=args.r is None,
56-
single=args.no_multi,
56+
single=not args.multi,
5757
)
5858
self._init_regularization(args)
5959

smcpp/commands/command.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,8 @@ def add_common_estimation_args(parser):
7878
default="L-BFGS-B", help="optimization algorithm. Powell's method "
7979
"is used by {P,MS}MC and does not require gradients. It may "
8080
"be faster in some cases.")
81-
optimizer.add_argument('--no-multi', default=False, action="store_true",
82-
help="do not update multiple blocks of coordinates at once")
81+
optimizer.add_argument('--multi', default=False, action="store_true",
82+
help="update multiple blocks of coordinates at once")
8383
optimizer.add_argument("--ftol", type=float,
8484
default=smcpp.defaults.ftol,
8585
help="stopping criterion for relative improvement in loglik "

smcpp/optimize/optimizers.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -237,9 +237,10 @@ def __init__(self, analysis, algorithm, xtol, ftol, single):
237237

238238
def _coordinates(self):
239239
model = self._analysis.model
240+
ret = [range(model.K)]
240241
if self._single:
241-
return [[k] for k in range(model.K)][::-1] # + [list(range(K // 3))]
242-
return [range(model.K)]
242+
ret = [[k] for k in range(model.K)][::-1] # + [list(range(K // 3))]
243+
return ret
243244

244245

245246
class TwoPopulationOptimizer(SMCPPOptimizer):

0 commit comments

Comments
 (0)