Skip to content

Commit dad595c

Browse files
committed
[core] tweak defaults
1 parent c31a5aa commit dad595c

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

smcpp/defaults.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
additional_knots = [2]
2-
regularization_penalty = 6
2+
regularization_penalty = 7
33
xtol = .1
44
ftol = 1e-4
55
pieces = 100
6-
knots = 32
6+
knots = 10
77
minimum = 1e-4
88
maximum = 1e4
99
M = 40

smcpp/model.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def regularizer(self):
4141
y = ad.admath.log(a)
4242
rd = smcpp.defaults.regularization_degree
4343
cs = np.cumsum(self.s)[:-rd]
44-
d1 = np.diff(y, rd) * np.exp(-cs)
44+
d1 = np.diff(y, rd)
4545
r1 = abs(d1 ** rd).sum() ** (1. / rd)
4646
return r1
4747

smcpp/optimize/optimizers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ def __init__(self, analysis, algorithm, xtol, ftol):
203203
def _coordinates(self):
204204
model = self._analysis.model
205205
K = model.K - 1
206-
return [[k] for k in range(K)][::-1] + [list(range(K // 3))]
206+
return [[k] for k in range(K)][::-1] # + [list(range(K // 3))]
207207

208208
class TwoPopulationOptimizer(SMCPPOptimizer):
209209
'Model fitting for two populations.'

smcpp/optimize/plugins/scale_optimizer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
logger = getLogger(__name__)
88

99
class ScaleOptimizer(OptimizerPlugin):
10-
DISABLED = True
10+
DISABLED = False
1111
def _f(self, alpha, x0, analysis):
1212
analysis.model[:] = x0 + alpha
1313
ret = float(analysis.Q())

0 commit comments

Comments
 (0)