switched to centos stream 8 image, added building of aardvark-dns, up… #3
Conversation
…dated podman and dependencies
popsUlfr
left a comment
popsUlfr
left a comment
There was a problem hiding this comment.
Sorry for taking so long to check out the pull request. Great work!
There seem to be unneeded files that could be removed.
The .gitignore has a lot of generic rules.
If the crun.static binary has been renamed then it should also patch the new name in the config file from the entrypoint.sh.
| chmod +x "$pkgname-static" | ||
| mkdir -p "$pkgdir/usr/bin" | ||
| cp crun.static "$pkgdir/usr/bin/" | ||
| cp "$pkgname-static" "$pkgdir/usr/bin/crun-static" |
There was a problem hiding this comment.
You've renamed crun.static to crun-static here but it's still patched as crun.static in the config file in the entrypoint.sh.
| # Windows shortcuts | ||
| *.lnk | ||
|
|
||
| build.log |
There was a problem hiding this comment.
There are too many generic rules in the .gitignore it should be kept to a minimum in my opinion.
| @@ -0,0 +1,7 @@ | |||
| FROM quay.io/centos/centos:stream8 | |||
There was a problem hiding this comment.
I don't think this file is needed to build the project ?
| ``` | ||
| And invoke `podman` directly: | ||
|
|
||
| Noww invoke `podman` directly: |
| @@ -0,0 +1,72 @@ | |||
| autoconf | |||
There was a problem hiding this comment.
This is linked to the Containerfile I guess, I think this is not needed to build the project too ?
Also the justfile seems to be an oversight ?
| #!/usr/bin/env bash | ||
| #set -eux | ||
|
|
||
| if [ $# -ne 1 ] || [[ "$1" == "-h" ]]; then |
There was a problem hiding this comment.
Might as well use [[ ]] for both tests ?
2 participants
refactored some code, updated podman and dependencies