SecurityListView: Allow to filter by options and non-options#4827
Open
pfalcon wants to merge 2 commits intoportfolio-performance:masterfrom
Open
SecurityListView: Allow to filter by options and non-options#4827pfalcon wants to merge 2 commits intoportfolio-performance:masterfrom
pfalcon wants to merge 2 commits intoportfolio-performance:masterfrom
Conversation
Contributor
Author
|
As discussed in #4825 (comment) |
Contributor
Author
|
@buchen : Can you please review this? Code-wise, it's pretty simple. But it adds initial support for options, where there was none before. But that's again the whole idea - to start adding it in simple and gentle manner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In security list view, add "Securities - options" and "Securities - non-options" filter choices beneath "Only securities". Option are time-limited and new-always-coming type of security, so over time, a large number of symbols can accumulate in portfolio, which clutter the view. It's expected that people may want to have "Securities - non-options" selected most of the time, and switch to option view as needed.