Skip to content

Win installer - add option to install in Current User (default) or All Users #5276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arnonm wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Win installer - add option to install in Current User (default) or All Users #5276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
145 changes: 127 additions & 18 deletions portfolio-product/installer/installer.nsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,20 @@
!define APPINI "PortfolioPerformance.ini"
!define FOLDER_NAME "PortfolioPerformance"
!define INPUT_DIR "..\target\products\name.abuchen.portfolio.distro.product\win32\win32\x86_64\portfolio"
!define INSTDIR "$LOCALAPPDATA\Programs\${FOLDER_NAME}"
!define INSTALLSIZE 177818 # size (in kB)
!define PUBLISHER "Andreas Buchen"

!include nsDialogs.nsh
!include LogicLib.nsh
!include FileFunc.nsh

RequestExecutionLevel user

Var InstallType
Var InstallTypeFromCmdLine
Var Dialog
Var RadioUser
Var RadioAllUsers

OutFile "..\target\products\${EXECUTABLENAME}-${SOFTWARE_VERSION}-setup.exe"
Name "${APPNAME}"
Expand All @@ -25,11 +34,88 @@ ShowInstDetails nevershow
InstProgressFlags smooth
ManifestDPIAware true

InstallDir "${INSTDIR}"

Page custom InstallTypePage InstallTypePageLeave
Page directory
Page instfiles


Function .onInit
Var /GLOBAL cmdLineParams
Var /GLOBAL allUsersFlag
Var /GLOBAL currentUserFlag

StrCpy $InstallType "user"
StrCpy $InstallTypeFromCmdLine "0"
StrCpy $INSTDIR "$LOCALAPPDATA\Programs\${FOLDER_NAME}"

# Check for command line parameters
${GetParameters} $cmdLineParams

# Check for /AllUsers flag
ClearErrors
${GetOptions} $cmdLineParams "/AllUsers" $allUsersFlag
${IfNot} ${Errors}
StrCpy $InstallType "allusers"
StrCpy $INSTDIR "$PROGRAMFILES\${FOLDER_NAME}"
StrCpy $InstallTypeFromCmdLine "1"
${EndIf}

# Check for /CurrentUser flag
ClearErrors
${GetOptions} $cmdLineParams "/CurrentUser" $currentUserFlag
${IfNot} ${Errors}
StrCpy $InstallType "user"
StrCpy $INSTDIR "$LOCALAPPDATA\Programs\${FOLDER_NAME}"
StrCpy $InstallTypeFromCmdLine "1"
${EndIf}
FunctionEnd

Function InstallTypePage
# Skip this page if installation type was specified via command line
${If} $InstallTypeFromCmdLine == "1"
Abort
${EndIf}

nsDialogs::Create 1018
Pop $Dialog

${If} $Dialog == error
Abort
${EndIf}

${NSD_CreateLabel} 0 0 100% 24u "Choose installation type:"
Pop $0

${NSD_CreateRadioButton} 10 30u 100% 12u "Install for current user only (recommended)"
Pop $RadioUser
${NSD_OnClick} $RadioUser OnRadioUser

${NSD_CreateRadioButton} 10 50u 100% 12u "Install for all users (requires administrator privileges)"
Pop $RadioAllUsers
${NSD_OnClick} $RadioAllUsers OnRadioAllUsers

${If} $InstallType == "user"
${NSD_Check} $RadioUser
${Else}
${NSD_Check} $RadioAllUsers
${EndIf}

nsDialogs::Show
FunctionEnd

Function OnRadioUser
StrCpy $InstallType "user"
StrCpy $INSTDIR "$LOCALAPPDATA\Programs\${FOLDER_NAME}"
FunctionEnd

Function OnRadioAllUsers
StrCpy $InstallType "allusers"
StrCpy $INSTDIR "$PROGRAMFILES\${FOLDER_NAME}"
FunctionEnd

Function InstallTypePageLeave
FunctionEnd

Section

Var /GLOBAL APPNAMEFULL
Expand All @@ -45,17 +131,17 @@ Section

# all files
#SetOverWrite try
File /r "${INPUT_DIR}\*"
File /r /x "p2" "${INPUT_DIR}\*"

# uninstall.exe
WriteUninstaller "$INSTDIR\uninstall.exe"

AccessControl::GrantOnFile "$INSTDIR" "(BU)" "GenericRead + GenericWrite + Delete"
Pop $0
${If} $0 == error
Pop $0
DetailPrint `AccessControl error: $0`
${EndIf}
# AccessControl plugin not available in standard NSIS installation
# AccessControl::GrantOnFile "$INSTDIR" "(BU)" "GenericRead + GenericWrite + Delete"
# Pop $0
# ${If} $0 == error
# Pop $0
# DetailPrint `AccessControl error: $0`
# ${EndIf}
Comment on lines -52 to +144
Copy link
Member

@buchen buchen Jan 6, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that the plugin is not available in a standard NSIS installation. It needs to be installed.

The purpose is this: if the application is installed into the system location, then the self-update of Eclipse needs the additional permissions. I added this a long time ago because otherwise users get error messages when updating the installation.

My thinking is: we can "just" keep it here as it is. Why? If the user installs for "All users", then he must already have the permission to run GrantOnFile. If the user installed for the current user only, it is not really needed, but it also does not make a difference if it is called.

What do you think?

Copy link
Member

@buchen buchen Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arnonm ?

Copy link
Contributor Author

@arnonm arnonm Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. It is not worth the overhead of installing the additional plugin


# shortcuts
CreateDirectory "$SMPROGRAMS\$APPNAMEFULL"
Expand All @@ -64,25 +150,44 @@ Section
WriteINIStr "$SMPROGRAMS\$APPNAMEFULL\$APPNAMEFULL Forum.URL" "InternetShortcut" "URL" "https://forum.portfolio-performance.info"
CreateShortCut "$SMPROGRAMS\$APPNAMEFULL\Uninstall $APPNAMEFULL.lnk" "$INSTDIR\uninstall.exe"

# register uninstaller
# see http://nsis.sourceforge.net/A_simple_installer_with_start_menu_shortcut_and_uninstaller
# register uninstaller based on installation type
${If} $InstallType == "allusers"
SetShellVarContext all
WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "DisplayName" "$APPNAMEFULL"
WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "UninstallString" "$\"$INSTDIR\uninstall.exe$\""
WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "QuietUninstallString" "$\"$INSTDIR\uninstall.exe$\" /S"
WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "InstallLocation" "$\"$INSTDIR$\""
WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "DisplayIcon" "$\"$INSTDIR\${APPEXE}$\""
WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "DisplayVersion" "${SOFTWARE_VERSION}"
WriteRegStr HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "Publisher" "${PUBLISHER}"
WriteRegDWORD HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "NoModify" 1
WriteRegDWORD HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "NoRepair" 1
WriteRegDWORD HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "EstimatedSize" ${INSTALLSIZE}
${Else}
SetShellVarContext current
WriteRegStr HKCU "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "DisplayName" "$APPNAMEFULL"
WriteRegStr HKCU "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "UninstallString" "$\"$INSTDIR\uninstall.exe$\""
WriteRegStr HKCU "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "QuietUninstallString" "$\"$INSTDIR\uninstall.exe$\" /S"
WriteRegStr HKCU "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "InstallLocation" "$\"$INSTDIR$\""
WriteRegStr HKCU "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "DisplayIcon" "$\"$INSTDIR\${APPEXE}$\""
WriteRegStr HKCU "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "DisplayVersion" "${SOFTWARE_VERSION}"
WriteRegStr HKCU "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "Publisher" "${PUBLISHER}"
# there is no option for modifying or repairing the install
WriteRegDWORD HKCU "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "NoModify" 1
WriteRegDWORD HKCU "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "NoRepair" 1
# set the INSTALLSIZE constant (!defined at the top of this script) so Add/Remove Programs can accurately report the size
WriteRegDWORD HKCU "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "EstimatedSize" ${INSTALLSIZE}
WriteRegDWORD HKCU "Software\Microsoft\Windows\CurrentVersion\Uninstall\$APPNAMEFULL" "EstimatedSize" ${INSTALLSIZE}
${EndIf}

SectionEnd

Section "Uninstall"

# Detect installation type from registry
ReadRegStr $0 HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\${APPNAME}" "DisplayName"
${If} $0 != ""
SetShellVarContext all
${Else}
SetShellVarContext current
${EndIf}
# all files but not workspace
RMDir /r $INSTDIR\configuration
RMDir /r $INSTDIR\features
Expand All @@ -93,8 +198,12 @@ Section "Uninstall"
Delete $INSTDIR\${APPINI}

# remove uninstaller from the registry
DeleteRegKey HKCU "Software\Microsoft\Windows\CurrentVersion\Uninstall\${APPNAME}"

ReadRegStr $0 HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\${APPNAME}" "DisplayName"
${If} $0 != ""
DeleteRegKey HKLM "Software\Microsoft\Windows\CurrentVersion\Uninstall\${APPNAME}"
${Else}
DeleteRegKey HKCU "Software\Microsoft\Windows\CurrentVersion\Uninstall\${APPNAME}"
${EndIf}
# remove shortcuts
RMDir /r "$SMPROGRAMS\${APPNAME}"
# Delete "$SMPROGRAMS\${APPNAME}"
Expand Down