Skip to content

Support different theming for positive/negative colors#5363

Merged
buchen merged 7 commits intoportfolio-performance:masterfrom
buchen:feature/value_color_scheme
Feb 14, 2026
Merged

Support different theming for positive/negative colors#5363
buchen merged 7 commits intoportfolio-performance:masterfrom
buchen:feature/value_color_scheme

Conversation

@buchen
Copy link
Member

@buchen buchen commented Jan 23, 2026

See discussion in #5362

@buchen
Copy link
Member Author

buchen commented Jan 23, 2026

@liuhaoXD can you have a look and comment on the code?

Open:

  • when switching the color scheme, it is not applied to existing tables. One has to change the view
  • no dynamic rendering of the up and down arrows
  • theme 'automatic' not renamed to 'sync with OS' (separate pull request)

@buchen
Copy link
Member Author

buchen commented Feb 3, 2026

@liuhaoXD any feedback - and possibly colors for another schema more fitting for Asia?

@buchen buchen force-pushed the feature/value_color_scheme branch from e0d441b to 53cbe79 Compare February 14, 2026 19:31
@buchen buchen merged commit 53cbe79 into portfolio-performance:master Feb 14, 2026
2 checks passed
@buchen buchen deleted the feature/value_color_scheme branch February 17, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant

Comments