Allow negative values (on CSV import, and in UI)#5376
Closed
aanno wants to merge 52 commits intoportfolio-performance:masterfrom
Closed
Allow negative values (on CSV import, and in UI)#5376aanno wants to merge 52 commits intoportfolio-performance:masterfrom
aanno wants to merge 52 commits intoportfolio-performance:masterfrom
Conversation
Author
|
What works now:
Closed in favour of #5445 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a WIP/Draft for relaxing the restriction of providing positive values for the most input and CSV fields.
Here are some relevant links for discussion why this might be useful:
What works now:
What does not work (needs improvements):
This is a draft implementation not ready for merging. It's main purpose is to find out if such a contribution would be accepted. The real implementation should