Started unit tests for BuySellModel.#5434
Merged
buchen merged 1 commit intoportfolio-performance:masterfrom Feb 15, 2026
Merged
Started unit tests for BuySellModel.#5434buchen merged 1 commit intoportfolio-performance:masterfrom
buchen merged 1 commit intoportfolio-performance:masterfrom
Conversation
Member
|
? For what? |
Contributor
Author
For avoidance of regressions by a new feature that I am working on. And to rule out regressions in these critical calculations in general. |
Contributor
Author
|
Fwiw, the commits are now also included with pull request #5454 Still, the proposed change is independent and meant to provide some value on its own. |
Mainly targeting the multi-directional update rules and error checking found in the AbstractSecurityModel base class. Issue: portfolio-performance#5434
buchen
force-pushed
the
security_model_tests
branch
from
b21dfb5 to
f7e6e0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly targetting the multi-directional update rules and error checking found in the AbstractSecurityModel base class.
To increase coverage, the expected PropertyChange events, currency conversions and more error cases should be checked as well.