Started unit tests for BuySellModel.#5434
Open
hporten wants to merge 2 commits intoportfolio-performance:masterfrom
Open
Started unit tests for BuySellModel.#5434hporten wants to merge 2 commits intoportfolio-performance:masterfrom
hporten wants to merge 2 commits intoportfolio-performance:masterfrom
Conversation
Mainly targetting the multi-directional update rules and error checking found in the AbstractSecurityModel base class. To increase coverage, the expected PropertyChange events, currency conversions and more error cases should be checked as well.
Member
|
? For what? |
Contributor
Author
For avoidance of regressions by a new feature that I am working on. And to rule out regressions in these critical calculations in general. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly targetting the multi-directional update rules and error checking found in the AbstractSecurityModel base class.
To increase coverage, the expected PropertyChange events, currency conversions and more error cases should be checked as well.