add filter by account in the Trades view#5463
Open
mierin12 wants to merge 1 commit intoportfolio-performance:masterfrom
Open
add filter by account in the Trades view#5463mierin12 wants to merge 1 commit intoportfolio-performance:masterfrom
mierin12 wants to merge 1 commit intoportfolio-performance:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1597 for the account part
Issue https://forum.portfolio-performance.info/t/filter-trades-view-by-account/38850
Issue https://forum.portfolio-performance.info/t/weitere-filter-bei-trades-unter-dem-reiter-berichte-fur-einzelne-depots/21955
Hello this is a proposition to add to the Trades view a filter by account.
If I am not mistaken, this works for the general use of the view. The change to the getPorfolio method is to get the correct logo in the portfolio column, as LogoManager does not recognize ReadOnlyPortfolio from a filtered client.
What I am not sure is what to do when we get to the Trades view from the widgets. Currently the widgets comes into the view with a list of trades already collected.
What should then happen with such a preselected trades when the account filter is changed on the view ? Should it reset the preselected trades to honor the new account selection ? Should it further filter the preselected trades in case a "smaller" account is selected ? Currently is has no effect, so can be a strange behavior for the user.
To be noted that if a filter account is already set on the view and the widget is collecting trades for another account, the activated view will be empty. But this is already the case with the other filtering option (if the view is set as Open Trades only, while the widget looks for Closed Trades -> empty view until Closed Trades is manually selected).
Instead of setting the input already calculated, should the widget only gives the reference of the filter to apply both for account and Closed Trades ?
I am not sure of the behavior you want to see for this widget-to-view compatibility.