Deutsche Bank: recognize documents of type "Vorabpauschale"#5537
Closed
hporten wants to merge 1 commit intoportfolio-performance:masterfrom
Closed
Deutsche Bank: recognize documents of type "Vorabpauschale"#5537hporten wants to merge 1 commit intoportfolio-performance:masterfrom
hporten wants to merge 1 commit intoportfolio-performance:masterfrom
Conversation
gamue
reviewed
Mar 1, 2026
| new AssertImportActions().check(results, "EUR"); | ||
|
|
||
| // check security | ||
| var security = results.stream().filter(SecurityItem.class::isInstance).findFirst() |
Contributor
There was a problem hiding this comment.
Could you please change the assertions for security & transaction to the newer style?
Example: https://github.com/portfolio-performance/portfolio/blob/master/CONTRIBUTING.md#pdf-importers
Contributor
Author
There was a problem hiding this comment.
Done! And sorry for having copied&pasted an outdated example without thinking.
In the end, the matching patterns from Postbank were reusable to a very large degree.
hporten
force-pushed
the
db_vorabpauschale
branch
from
5d03294 to
4daba5c
Compare
Nirus2000
reviewed
Mar 2, 2026
Member
There was a problem hiding this comment.
Ich hatte 3 Minuten Zeit... und meine Anmerkungen.
Cooler würde ich es finden, wenn du die Zeit findest, die Skipped Transactions weiter zu bereinigen oder meinst du nicht? Ich frage nur für die Kollegen und anderen Contributer....
Ich sehe es positiv, dass du da bereits eifrig mithilfst....
Cool... Let's go!
....abuchen.portfolio/src/name/abuchen/portfolio/datatransfer/pdf/DeutscheBankPDFExtractor.java
Show resolved
Hide resolved
....abuchen.portfolio/src/name/abuchen/portfolio/datatransfer/pdf/DeutscheBankPDFExtractor.java
Show resolved
Hide resolved
Nirus2000
reviewed
Mar 2, 2026
...s/src/name/abuchen/portfolio/datatransfer/pdf/deutschebank/DeutscheBankPDFExtractorTest.java
Show resolved
Hide resolved
buchen
pushed a commit
that referenced
this pull request
Mar 2, 2026
Issue: #5537 Signed-off-by: Harri Porten <hporten@mailbox.org> [added second test case with zero taxes; rebased to master] Signed-off-by: Andreas Buchen <andreas.buchen@gmail.com>
Member
|
merged. Thanks @hporten |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the end, the matching patterns from Postbank were reusable to a very large degree.