Skip to content

Update: 2025_Lazaridis_Yamnaya#203

Merged
TCLamnidis merged 4 commits intomainfrom
update_2025_Lazaridis_Yamnaya
Mar 26, 2026
Merged

Update: 2025_Lazaridis_Yamnaya#203
TCLamnidis merged 4 commits intomainfrom
update_2025_Lazaridis_Yamnaya

Conversation

@TCLamnidis
Copy link
Copy Markdown
Member

@TCLamnidis TCLamnidis commented Mar 26, 2026

This updates the recipe for 2025_Lazaridis_Yamnaya, to include some data that were missing from the original recipe due to an issue during data upload to then ENA. The authors have fixed the issue and the recipe is being updated to reflect the latest version of the dataset.

For each of the added SSF rows, I have taken the poseidon ID, and udg, library_built and notes info from the equivalent existing row of the MT data.

Linked to #65

PR Checklist

  • The PR title is in the format Add/Update package: {package_name}.
  • The PR description includes a link to the issue requesting the package its
    update. (Add to Linked to #XXX above.)

If adding or updating a package:

SSF file Todo list

  • This PR contains a sequencingSourceFile (.ssf) for the requested
    package.
  • The name of the .ssf file(s) matches the package name (i.e.
    packages/2023_my_package/2023_my_package.ssf).
  • The .ssf file MUST contain a new line at the end of the file.
    A check for this exists in the CI. This check should pass before
    you continue with this list.
  • I confirm that the poseidon_IDs, udg, and library_built are filled
    and correct.
  • I made sure to leave notes where necessary to explain any special
    cases/judgement calls made for data entries.

Include a Janno file

It is recommended that you include a janno file for the requested package to the PR.
While optional, recipes that include a janno file will be prioritised for processing.

  • (optional) This PR contains a janno file (.janno) for the requested
    package.
    • The name of the .janno file(s) matches the package name (i.e.
      packages/2023_my_package/2023_my_package.janno).
    • The .janno file contains one record per poseidon_id specified in the SSF file.

Recipe creation and validation

  • Comment @delphis-bot create recipe to this pull request to awaken
    Poseidon's trusty helper. (This should be repeated whenever changes are
    made to the SSF file contents).

After a few second, Delphis-bot will add a number of files to the PR.
Using the 'Files changed' tab, check that all of the following files were added:

  • The file packages/{package_name}/{package_name}.tsv was added to the PR.
  • The file packages/{package_name}/{package_name}.tsv_patch.sh was added
    to the PR from template.
  • The file packages/{package_name}/script_versions.txt was added to the
    PR.
  • The file packages/{package_name}/{package_name}.config was added to the
    PR from template.

Additional configuration

Additional configuration may be required when processing the data through nf-core/eager.
If you think this may be the case here, please either leave a comment about it in the PR or
add the relevant parameters within the params section at the end of the package config file.
For example, if the published data from the paper have internal barcodes, please mention that
in a comment, or provide the relevant nf-core/eager parameters in the params section.

  • If any nf-core/eager parameters need to be altered from their defaults, I
    have commented so in this PR (or added the relevant parameters within the
    params section at the end of the package config file).

@TCLamnidis
Copy link
Copy Markdown
Member Author

@delphis-bot create recipe

@TCLamnidis TCLamnidis merged commit e573d65 into main Mar 26, 2026
5 checks passed
@TCLamnidis TCLamnidis deleted the update_2025_Lazaridis_Yamnaya branch March 26, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant