-
Notifications
You must be signed in to change notification settings - Fork 4
Changes to .janno and .ssf columns for Poseidon v3.0.0 #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: Schema_300_dev
Are you sure you want to change the base?
Conversation
…e for packages in old Poseidon versions
…o added row-wise consistency checks accordingly
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## Schema_300_dev #357 +/- ##
==================================================
- Coverage 56.89% 55.68% -1.22%
==================================================
Files 33 33
Lines 5043 5237 +194
Branches 548 632 +84
==================================================
+ Hits 2869 2916 +47
- Misses 1626 1689 +63
- Partials 548 632 +84 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks, I will take a look. |
…lumns when writing .janno files
.janno column sorting with special treatment of `_Note` columns
|
Meeting 2025/12/01: Clemens goes through this PR and documents it properly to make a review possible. |
|
This PR is pretty straight forward, actually. It just adds new columns and some special handling for the ones whose semantics change with Poseidon v3.0.0. This affects so many files because changes in the .janno columns change a lot of reference data for the golden tests. The only interesting bit is the way There are still two open PRs in the schema repository that should be worked into this PR, as soon as they are merged:
When this is done, the review can proceed. |
…s depending on the poseidon package version
.janno & .ssf field parsing depending on a package's Poseidon version
|
OK - I think this is ready for review. It seems overwhelming with all these files affected, but the actual changes are realtively minimal. I suggest you start in src/Poseidon/ColumnTypesUtils.hs. That's where the new |
This PR is part of the preparation for Poseidon v3.0.0 as specified here: poseidon-framework/poseidon-schema#93
As documented in #351 I implemented the changes to .janno and .ssf.
While doing so I noticed two minor things I wanted to change in the new schema specification: poseidon-framework/poseidon-schema@31900ef & poseidon-framework/poseidon-schema@a256a62
Adding and modifying the columns in poseidon-hs also required (or: made desirable) some minor changes in the surrounding code -- but nothing spectacular.