Shut down DAP server gracefully on disconnection #1018
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched on #1016.
Follow up to posit-dev/positron#11407 and posit-dev/positron#11497 where we disabled the exthost restart test on Windows (Slack discussion at https://positpbc.slack.com/archives/C06DNFJSHPD/p1769113239000079).
Not sure what this only surfaced on Windows, but the cause was an Ark crash due to sloppy Unwraps on connection events. This PR makes sure connection errors are propagated, logged, and cause the DAP server to shut down gracefully.
It was a bit tricky to debug because the logs were not showing the crash. The only clue that surfaced was a message in the Console:
and these messages in the Supervisor logs:
0xc0000409is the code forSTATUS_STACK_BUFFER_OVERRUN.Attaching Ark with a debugger then restarting the exthost gave enough time to the process to emit log messages before exit, revealing the DAP panic.