Skip to content

Don't fail if folder has no INDEX file #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lionel- wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −9
Open

Don't fail if folder has no INDEX file #1078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions crates/ark/src/lsp/inputs/package_index.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,7 @@ impl Index {

let index_path = path.join("INDEX");
if !index_path.is_file() {
return Err(anyhow::anyhow!(
"Can't load index as '{path}' does not contain an INDEX file",
path = path.to_string_lossy()
));
return Ok(Self::default());
}

let contents = std::fs::read_to_string(&index_path)?;
Expand Down Expand Up @@ -148,16 +145,17 @@ Nelder_Mead Nelder-Mead Optimization of Parameters,
}

#[test]
fn load_from_folder_returns_errors() {
// From a file
fn load_from_folder_returns_error_for_file() {
let file = tempfile::NamedTempFile::new().unwrap();
let result = Index::load_from_folder(file.path());
assert!(result.is_err());
}

// From a dir without an INDEX file
#[test]
fn load_from_folder_returns_default_without_index() {
let dir = tempdir().unwrap();
let result = Index::load_from_folder(dir.path());
assert!(result.is_err());
let idx = Index::load_from_folder(dir.path()).unwrap();
assert!(idx.names.is_empty());
}

#[test]
Expand Down