Implement hit count breakpoints#1087
Open
lionel- wants to merge 2 commits intofeature/log-breakpointsfrom
Open
Implement hit count breakpoints#1087lionel- wants to merge 2 commits intofeature/log-breakpointsfrom
lionel- wants to merge 2 commits intofeature/log-breakpointsfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branched from #1086 .
Adds support for DAP hit count breakpoints. When a breakpoint has a
hitCondition, the breakpoint location must be reached at least that many times before it fires. The value is interpreted as a plain integer with>=semantics. For more complex hit patterns, users can combine hit counts with conditional breakpoints.Hit counts are reset when
ReadConsolereturns to a top-level (non-browser) prompt, meaning the execution that may have hit breakpoints is complete. This way counts survive across continue/step within a debug session but start fresh for new sessions.Hit count integrates with the existing breakpoint feature chain. Hit counts with conditions require both to be satisfied, and hit counts with log messages only emit output once the threshold is reached. If the hit count can't be parsed, the error message is propagated to the Console in breakpoint fences with a clickable link.
QA Notes
Tested on the backend side.
Hit counts should behave well on their own or in combination with logpoints and conditional breakpoints. Parse errors appear in the console.