Skip to content

Initialize graphics device on startup #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Initialize graphics device on startup #895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions crates/ark/src/interface.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,16 @@ impl RMain {
startup::source_user_r_profile();
}

// Initialise graphics device so `grDevices::dev.interactive()` returns `TRUE`.
// See https://github.com/posit-dev/positron/issues/7681.
// Needs to happen _after_ sourcing R profiles so users can override the
// graphics device in Rprofile.
unsafe {
if let Err(err) = graphics_device::ps_graphics_device_impl() {
log::warn!("Can't initialize graphics device: {err:?}");
}
}

// Start the REPL. Does not return!
crate::sys::interface::run_r();
}
Expand Down
2 changes: 1 addition & 1 deletion crates/ark/src/plots/graphics_device.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,7 +899,7 @@ unsafe extern "C-unwind" fn callback_new_page(dd: pGEcontext, dev: pDevDesc) {
});
}

unsafe fn ps_graphics_device_impl() -> anyhow::Result<SEXP> {
pub(crate) unsafe fn ps_graphics_device_impl() -> anyhow::Result<SEXP> {
// TODO: Don't allow creation of more than one graphics device.

// Create the graphics device.
Expand Down
Loading