Code-sign ark binaries on Windows #985
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,6 @@ jobs: | |
|
|
||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| strategy: | ||
| matrix: | ||
|
|
@@ -45,17 +44,60 @@ jobs: | |
| cargo clean | ||
| cargo build ${{ matrix.flavor == 'release' && '--release' || '' }} --target ${{ matrix.rust_target_prefix }}-pc-windows-msvc | ||
|
|
||
| - name: Upload unsigned executable for signing | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: ark-${{ matrix.flavor }}-windows-${{ matrix.arch }}-unsigned | ||
| path: target\${{ matrix.rust_target_prefix }}-pc-windows-msvc\${{ matrix.flavor }}\ark.exe | ||
|
|
||
| sign_windows: | ||
| name: "Sign Windows Binaries" | ||
| uses: posit-dev/posit-gh-actions/.github/workflows/sign-windows.yml@main | ||
|
Contributor
There was a problem hiding this comment. Is
Contributor
Author
There was a problem hiding this comment. Kind of! It's one of our "Posit Larger Runners". IIRC it is not hosted by Posit but we do pay for it via Github Enterprise. |
||
| needs: [build_windows] | ||
| secrets: inherit | ||
| strategy: | ||
| matrix: | ||
| arch: [x64, arm64] | ||
|
Contributor
There was a problem hiding this comment. I assume that whatever arch
Contributor
Author
There was a problem hiding this comment. Good question; yes, it can. It's been code signing the arm64 version of Positron for a few months now. |
||
| flavor: [debug, release] | ||
| with: | ||
| unsigned_artifact_name: ark-${{ matrix.flavor }}-windows-${{ matrix.arch }}-unsigned | ||
| signed_artifact_name: ark-${{ matrix.flavor }}-windows-${{ matrix.arch }}-signed | ||
|
|
||
| repackage_signed_windows: | ||
| name: Repackage Signed Windows Binaries | ||
| runs-on: windows-latest | ||
| needs: [sign_windows] | ||
| timeout-minutes: 10 | ||
|
|
||
| env: | ||
| DEBUG_FLAG: ${{ matrix.flavor == 'debug' && '-debug' || '' }} | ||
|
|
||
| strategy: | ||
| matrix: | ||
| arch: [x64, arm64] | ||
| flavor: [debug, release] | ||
|
|
||
| steps: | ||
| - name: Checkout sources | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Download signed executable | ||
| uses: actions/download-artifact@v4 | ||
| with: | ||
| name: ark-${{ matrix.flavor }}-windows-${{ matrix.arch }}-signed | ||
| path: signed | ||
|
|
||
| - name: Create signed archive | ||
| shell: pwsh | ||
| run: | | ||
| # Compress the signed kernel to an archive | ||
| $params = @{ | ||
| Path = "signed\ark.exe", "LICENSE", "crates\ark\NOTICE" | ||
| DestinationPath = "ark-${{ inputs.version }}${{ env.DEBUG_FLAG }}-windows-${{ matrix.arch }}.zip" | ||
| } | ||
| Compress-Archive @params | ||
|
|
||
| - name: Upload signed archive | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: ark-${{ matrix.flavor }}-windows-${{ matrix.arch }}-archive | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove
DEBUG_FLAGfrombuild_windows:?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes! 3156b97